Re: [PATCH] Staging: Skein: Patch adds the test vectors

[Sudip Mukherjee <sudipm.mukherjee@gmail.com>]

On Sat, Dec 05, 2015 at 06:44:10AM -0500, Sanidhya Solanki wrote:
> The patch is included below.
> I would like to apologize for the past few emails. It turns out the
> documentation included in the eMail clients file is woefully out of
> date. I have checked the patches for errors using the scripts provided.
> However, it turns out that the scripts are slightly incorrect, as you
> can see when it keeps asking to align the statements with the brackets.
> Another issue has turned out to be that you cannot follow the scripts
> completely without altering the code in a significant way, as it
> suggests changing the deterministic portions of the hash, changing
> certain functions, reducing line length, etc.
> I have sent the patch to myself, applied it, as well as compared sha512
> hashes of both the original and the mailed copy.
> For the rest of the work on this patch and the skein subsystem, I defer
> to someone with the expertise and experience of making Linux modules
> and the skein hash families. I believe that if I continue to make
> further changes to these files, I might make a mistake which alters
> functionality of the hash function. I will continue to contribute to
> the other kernel branches.
> I will submit a patch to correct the email documentation tomorrow. 
> Thanks for you patience everyone.
> -----------------------------------------------------------------------

This should not be part of commit message. If you have to write
something then it should go in the comments section. And please test
your patch with checkpatch (preferably with --strict)  before sending.

regards
sudip