From: Dan Carpenter <dan.carpenter@oracle.com>
To: Saurabh Sengar <saurabh.truth@gmail.com>
Cc: devel@driverdev.osuosl.org, kirk@reisers.ca,
Greg KH <gregkh@linuxfoundation.org>,
speakup@linux-speakup.org, linux-kernel@vger.kernel.org,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
Christopher Brannon <chris@the-brannons.com>
Subject: Re: [PATCH] Staging: speakup: kobjects: Return the error type to caller
Date: Mon, 7 Dec 2015 11:31:09 +0300 [thread overview]
Message-ID: <20151207083109.GC18797@mwanda> (raw)
In-Reply-To: <CAA8avJ-DPgF4JwLuVQ=810cq3ONMUnbktVHe5_EggfbsKJtxzw@mail.gmail.com>
On Mon, Dec 07, 2015 at 12:46:37PM +0530, Saurabh Sengar wrote:
> >> @@ -688,6 +689,8 @@ ssize_t spk_var_store(struct kobject *kobj, struct kobj_attribute *attr,
> >>
> >> if (ret == -ERESTART)
> >> pr_info("%s reset to default value\n", param->name);
> >
> > Is this really true?
> Sorry, I am not sure here what you mean here.
> I have not implemented it.
> >
> > This function is so weird and broken. Please look at it some more and
> > fix it harder with a mallet.
> You mean I broke it ?
No, I mean it was broken to begin with. Write a more extensive patch to
fix it.
That printk should be moved up to where we actually do the reset.
Anyway speakup is actually really bad and there is a lot of broken
stuff so you don't have to fix this function if you don't want to. Just
fix the -ERANGE issue I mentioned and resend if you want.
regards,
dan carpenter
next prev parent reply other threads:[~2015-12-07 8:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 14:42 [PATCH] Staging: speakup: kobjects: Return the error type to caller Saurabh Sengar
2015-12-07 6:48 ` Dan Carpenter
2015-12-07 7:16 ` Saurabh Sengar
2015-12-07 8:31 ` Dan Carpenter [this message]
2015-12-07 9:59 ` [PATCH v2] " Saurabh Sengar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207083109.GC18797@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=saurabh.truth@gmail.com \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox