From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755896AbbLGL3T (ORCPT ); Mon, 7 Dec 2015 06:29:19 -0500 Received: from outbound-smtp09.blacknight.com ([46.22.139.14]:59707 "EHLO outbound-smtp09.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752897AbbLGL3S (ORCPT ); Mon, 7 Dec 2015 06:29:18 -0500 Date: Mon, 7 Dec 2015 11:29:09 +0000 From: Mel Gorman To: Michal Hocko Cc: "Michael S. Tsirkin" , Will Deacon , "Huang, Ying" , virtualization@lists.linux-foundation.org, LKML , Michal Hocko Subject: Re: [PATCH] virtio: Do not drop __GFP_HIGH in alloc_indirect Message-ID: <20151207112909.GH2015@techsingularity.net> References: <1448980369-27130-1-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1448980369-27130-1-git-send-email-mhocko@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 01, 2015 at 03:32:49PM +0100, Michal Hocko wrote: > From: Michal Hocko > > b92b1b89a33c ("virtio: force vring descriptors to be allocated from > lowmem") tried to exclude highmem pages for descriptors so it cleared > __GFP_HIGHMEM from a given gfp mask. The patch also cleared __GFP_HIGH > which doesn't make much sense for this fix because __GFP_HIGH only > controls access to memory reserves and it doesn't have any influence > on the zone selection. Some of the call paths use GFP_ATOMIC and > dropping __GFP_HIGH will reduce their changes for success because the > lack of access to memory reserves. > > Signed-off-by: Michal Hocko Reviewed-by: Mel Gorman It also has been tested by Ying Huang and found to have fixed a page allocation failure problem in 4.4-rc3 in the Intel 0-day testing infrastructure. -- Mel Gorman SUSE Labs