radeon -Wmaybe-uninitialized crap

radeon -Wmaybe-uninitialized crap

[Borislav Petkov]

Hi guys,

this just started appearing when building -rc4. Got fixes yet? :-)

In file included from drivers/gpu/drm/radeon/radeon_mode.h:37:0,
                 from drivers/gpu/drm/radeon/radeon.h:80,
                 from drivers/gpu/drm/radeon/r100.c:33:
drivers/gpu/drm/radeon/r100.c: In function ‘r100_bandwidth_update’:
include/drm/drm_fixed.h:64:13: warning: ‘crit_point_ff.full’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  u64 tmp = ((u64)A.full << 13);
             ^
drivers/gpu/drm/radeon/r100.c:3153:63: note: ‘crit_point_ff.full’ was declared here
  fixed20_12 peak_disp_bw, mem_bw, pix_clk, pix_clk2, temp_ff, crit_point_ff;
                                                               ^
drivers/gpu/drm/radeon/r100.c:3583:42: warning: ‘disp_drain_rate.full’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     temp_ff.full = read_return_rate.full - disp_drain_rate.full;
                                          ^
-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

RE: radeon -Wmaybe-uninitialized crap

[Deucher, Alexander]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1573 bytes --]



> -----Original Message-----
> From: Borislav Petkov [mailto:bp@alien8.de]
> Sent: Monday, December 07, 2015 3:56 AM
> To: Deucher, Alexander; Koenig, Christian
> Cc: lkml
> Subject: radeon -Wmaybe-uninitialized crap
> 
> Hi guys,
> 
> this just started appearing when building -rc4. Got fixes yet? :-)

Odd.  Nothing related to these variables has changed in years.

Alex

> 
> In file included from drivers/gpu/drm/radeon/radeon_mode.h:37:0,
>                  from drivers/gpu/drm/radeon/radeon.h:80,
>                  from drivers/gpu/drm/radeon/r100.c:33:
> drivers/gpu/drm/radeon/r100.c: In function ‘r100_bandwidth_update’:
> include/drm/drm_fixed.h:64:13: warning: ‘crit_point_ff.full’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
>   u64 tmp = ((u64)A.full << 13);
>              ^
> drivers/gpu/drm/radeon/r100.c:3153:63: note: ‘crit_point_ff.full’ was
> declared here
>   fixed20_12 peak_disp_bw, mem_bw, pix_clk, pix_clk2, temp_ff,
> crit_point_ff;
>                                                                ^
> drivers/gpu/drm/radeon/r100.c:3583:42: warning: ‘disp_drain_rate.full’ may
> be used uninitialized in this function [-Wmaybe-uninitialized]
>      temp_ff.full = read_return_rate.full - disp_drain_rate.full;
>                                           ^
> --
> Regards/Gruss,
>     Boris.
> 
> ECO tip #101: Trim your mails when you reply.
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: radeon -Wmaybe-uninitialized crap

[Borislav Petkov]

On Mon, Dec 07, 2015 at 04:15:22PM +0000, Deucher, Alexander wrote:
> Odd.  Nothing related to these variables has changed in years.

Odd indeed. Building that same config on two other boxes doesn't trip
those up so it must be something gcc-related on that particular box.

Hmmm.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Re: radeon -Wmaybe-uninitialized crap

[Borislav Petkov]

On Mon, Dec 07, 2015 at 06:10:02PM +0100, Borislav Petkov wrote:
> On Mon, Dec 07, 2015 at 04:15:22PM +0000, Deucher, Alexander wrote:
> > Odd.  Nothing related to these variables has changed in years.
> 
> Odd indeed. Building that same config on two other boxes doesn't trip
> those up so it must be something gcc-related on that particular box.

Just appeared on another box (ph) too:

In file included from drivers/gpu/drm/radeon/radeon_mode.h:37:0,
                 from drivers/gpu/drm/radeon/radeon.h:80,
                 from drivers/gpu/drm/radeon/r100.c:33:
drivers/gpu/drm/radeon/r100.c: In function ‘r100_bandwidth_update’:
include/drm/drm_fixed.h:64:13: warning: ‘crit_point_ff.full’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  u64 tmp = ((u64)A.full << 13);
             ^
drivers/gpu/drm/radeon/r100.c:3153:63: note: ‘crit_point_ff.full’ was declared here
  fixed20_12 peak_disp_bw, mem_bw, pix_clk, pix_clk2, temp_ff, crit_point_ff;
                                                               ^
drivers/gpu/drm/radeon/r100.c:3583:42: warning: ‘disp_drain_rate.full’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     temp_ff.full = read_return_rate.full - disp_drain_rate.full;
                                          ^
-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.