From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933545AbbLHQbc (ORCPT ); Tue, 8 Dec 2015 11:31:32 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:37444 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755772AbbLHQba (ORCPT ); Tue, 8 Dec 2015 11:31:30 -0500 Date: Tue, 08 Dec 2015 11:31:29 -0500 (EST) Message-Id: <20151208.113129.263389829273977789.davem@davemloft.net> To: rweikusat@mobileactivedefense.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix inverted test in __skb_recv_datagram From: David Miller In-Reply-To: <87h9jt809v.fsf@doppelsaurus.mobileactivedefense.com> References: <87vb8925vx.fsf_-_@doppelsaurus.mobileactivedefense.com> <20151207.222827.1680789119862020474.davem@davemloft.net> <87h9jt809v.fsf@doppelsaurus.mobileactivedefense.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 08 Dec 2015 08:31:30 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rainer Weikusat Date: Tue, 08 Dec 2015 14:47:56 +0000 > As the kernel generally uses negated error numbers, *err needs to be > compared with -EAGAIN (d'oh). > > Signed-off-by: Rainer Weikusat > Fixes: ea3793ee29d3 ("core: enable more fine-grained datagram reception control") Applied, thanks. Please, in the future, place proper subsystem prefixes in your Subject lines. In this case, "net: " would have been appropriate and it wouldn't be the end of the world if you capitalized your commit header line too. I fixed both of these things while installing your change. Thanks.