From: Lee Jones <lee.jones@linaro.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Support Opensource <support.opensource@diasemi.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: da9063: Allow modular build
Date: Tue, 8 Dec 2015 13:56:07 +0000 [thread overview]
Message-ID: <20151208135607.GI3384@x1> (raw)
In-Reply-To: <1449505003-5243-1-git-send-email-geert+renesas@glider.be>
On Mon, 07 Dec 2015, Geert Uytterhoeven wrote:
> Allow support for the DA9063 PMIC to be modular, cfr. DA9062, which
> allows to decrease size of multi-platform kernels (e.g.
> multi_v7_defconfig).
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
The DA9063 driver appears to contain all module code. In fact, I'm
surprised that it wasn't enabled for tristate in the first place.
In any case, it would be good to get a Reviewed/Acked-by from one of
the Dialog guys.
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 4d92df6ef9fe92ac..527ee7168617c933 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -211,7 +211,7 @@ config MFD_DA9062
> of the device.
>
> config MFD_DA9063
> - bool "Dialog Semiconductor DA9063 PMIC Support"
> + tristate "Dialog Semiconductor DA9063 PMIC Support"
> select MFD_CORE
> select REGMAP_I2C
> select REGMAP_IRQ
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-12-08 13:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 16:16 [PATCH] mfd: da9063: Allow modular build Geert Uytterhoeven
2015-12-08 13:56 ` Lee Jones [this message]
2015-12-08 14:53 ` Opensource [Steve Twiss]
2015-12-17 13:26 ` Opensource [Steve Twiss]
2016-01-11 6:41 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208135607.GI3384@x1 \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).