From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756858AbbLHO5G (ORCPT ); Tue, 8 Dec 2015 09:57:06 -0500 Received: from mail-pf0-f182.google.com ([209.85.192.182]:35893 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756539AbbLHO5D (ORCPT ); Tue, 8 Dec 2015 09:57:03 -0500 Date: Tue, 8 Dec 2015 20:26:58 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: linux-pm@vger.kernel.org, linaro-kernel@lists.linaro.org, ashwin.chaugule@linaro.org, "Rafael J. Wysocki" , LKML Subject: Re: [PATCH][experimantal] cpufreq: governor: Use an atomic variable for synchronization Message-ID: <20151208145658.GG3692@ubuntu> References: <10138182.WjU9yqx6Gs@vostro.rjw.lan> <20151208135518.GE3692@ubuntu> <1843141.WbisoTkq1u@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1843141.WbisoTkq1u@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08-12-15, 15:30, Rafael J. Wysocki wrote: > It doesn't look nice, but then having a lockless timer function is worth > it in my view. > > The code in gov_cancel_work() runs relatively rarely, but the timer > function can run very often, so avoiding the lock in there is a priority > to me. > > Plus we can avoid disabling interrupts in two places this way. Okay, that's good enough then. I hope you will be sending these patches now, right? And ofcourse, we need documentation in this case as well. -- viresh