From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751376AbbLHRWb (ORCPT ); Tue, 8 Dec 2015 12:22:31 -0500 Received: from mga11.intel.com ([192.55.52.93]:6133 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751002AbbLHRW3 (ORCPT ); Tue, 8 Dec 2015 12:22:29 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,400,1444719600"; d="scan'208";a="836935508" Date: Tue, 8 Dec 2015 22:55:34 +0530 From: Vinod Koul To: Andy Shevchenko Cc: "Rafael J . Wysocki" , linux-acpi@vger.kernel.org, dmaengine@vger.kernel.org, Thomas Gleixner , Greg Kroah-Hartman , Jarkko Nikula , linux-kernel@vger.kernel.org, Mika Westerberg Subject: Re: [PATCH v3 7/9] dmaengine: dw: platform: power on device on shutdown Message-ID: <20151208172534.GV1854@localhost> References: <1449265765-9393-1-git-send-email-andriy.shevchenko@linux.intel.com> <1449265765-9393-8-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449265765-9393-8-git-send-email-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 04, 2015 at 11:49:23PM +0200, Andy Shevchenko wrote: > We have to call dw_dma_disable() to stop any ongoing transfer. On some > platforms we can't do that since DMA device is powered off. Moreover we have no > possibility at that point to check if the platform is affected or not. That's > why we call pm_runtime_get_sync() / pm_runtime_put() unconditionally. On the > other hand we can't use pm_runtime_suspended() because runtime PM framework is > not fully used by the driver. Acked-by: Vinod Koul -- ~Vinod