From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752077AbbLHSt3 (ORCPT ); Tue, 8 Dec 2015 13:49:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37641 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751913AbbLHSt1 (ORCPT ); Tue, 8 Dec 2015 13:49:27 -0500 Date: Tue, 8 Dec 2015 12:49:26 -0600 From: Josh Poimboeuf To: Jiri Olsa Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Namhyung Kim Subject: Re: [PATCH v2 01/14] perf: Fix 'make clean' Message-ID: <20151208184926.GF14846@treble.redhat.com> References: <9debcfe34fda07d498fc9ed9083dc79ffff5b0b9.1449548395.git.jpoimboe@redhat.com> <20151208173734.GA18433@krava.brq.redhat.com> <20151208184043.GA14514@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151208184043.GA14514@krava.brq.redhat.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 08, 2015 at 07:40:43PM +0100, Jiri Olsa wrote: > On Tue, Dec 08, 2015 at 06:40:12PM +0100, Jiri Olsa wrote: > > On Mon, Dec 07, 2015 at 10:21:39PM -0600, Josh Poimboeuf wrote: > > > Add some missing files to the 'make clean' target. > > > > > > Reported-by: Jiri Olsa > > > Signed-off-by: Josh Poimboeuf > > > --- > > > tools/perf/Makefile.perf | 13 +++++++++++-- > > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > > > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > > > index 929a32b..8b63dbd 100644 > > > --- a/tools/perf/Makefile.perf > > > +++ b/tools/perf/Makefile.perf > > > @@ -584,13 +584,22 @@ config-clean: > > > $(call QUIET_CLEAN, config) > > > $(Q)$(MAKE) -C $(srctree)/tools/build/feature/ clean >/dev/null > > > > > > -clean: $(LIBTRACEEVENT)-clean $(LIBAPI)-clean $(LIBBPF)-clean config-clean > > > +feature-clean: > > > + $(call QUIET_CLEAN, feature) > > > + $(Q)$(RM) -r $(OUTPUT)feature > > > > that should be within feature dir > > > > > + > > > +tests-clean: > > > + $(call QUIET_CLEAN, tests) > > > + $(Q)find $(OUTPUT)tests -name '*.o' -delete -o -name '\.*.cmd' -delete > > > > hum, that'd be excuted twice (another one below) > > it also crashes build test (make -f tests/make) Thanks, I'll look into it. > > jirka > > [jolsa@krava perf]$ make -f tests/make make_clean_all_O > Testing Makefile > - make_clean_all_O: cd . && make -f Makefile O=/tmp/tmp.glBnmXFNzM DESTDIR=/tmp/tmp.S5f5hGWoVy clean all > cd . && make -f Makefile O=/tmp/tmp.glBnmXFNzM DESTDIR=/tmp/tmp.S5f5hGWoVy clean all > CLEAN libapi > CLEAN libtraceevent > CLEAN libbpf > CLEAN config > CLEAN feature > CLEAN tests > find: ‘/tmp/tmp.glBnmXFNzM/tests’: No such file or directory > Makefile.perf:592: recipe for target 'tests-clean' failed > make[3]: *** [tests-clean] Error 1 > make[3]: *** Waiting for unfinished jobs.... > Makefile:75: recipe for target 'clean' failed > make[2]: *** [clean] Error 2 > tests/make:249: recipe for target 'make_clean_all_O' failed > make[1]: *** [make_clean_all_O] Error 1 > tests/make:10: recipe for target 'make_clean_all_O' failed > make: *** [make_clean_all_O] Error 2 -- Josh