Re: [PATCH 3/7] cgroup: introduce cgroup namespaces

Serge E. Hallyn
2015-12-08T19:47:46Z

On Tue, Dec 08, 2015 at 02:46:00PM -0500, Tejun Heo wrote:
> Hello, Serge.
>
> On Tue, Dec 08, 2015 at 01:34:31PM -0600, Serge E. Hallyn wrote:
> > > I'd prefer collecting all ns related declarations in a single place.
> >
> > I can group some of them, but free_cgroup_ns needs the
> > cgroup_namespace definition, put_cgroup_ns() needs free_cgroup_ns(),
> > and free_cgroup_ns() is static in the !CONFIG_CGROUPS case and a
> > non-static function in the other case.
> >
> > So I'm going to put both get_cgroup_ns() and put_cgroup_ns() at the
> > end of the file, with the struct namespace define at the top. Is
> > that sufficient?
>
> I wouldn't even mind creating a separate #ifdef section for NS stuff
> if that's wnat's necessary for collecting everything into one spot.

Ok, will do that, thanks.