From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753181AbbLIQyx (ORCPT <rfc822;w@1wt.eu>);
	Wed, 9 Dec 2015 11:54:53 -0500
Received: from mga11.intel.com ([192.55.52.93]:24717 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752446AbbLIQyu (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 9 Dec 2015 11:54:50 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,404,1444719600"; 
   d="scan'208";a="837768574"
Date: Wed, 9 Dec 2015 08:53:55 -0800
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Radivoje Jovanovic <radivoje.jovanovic@intel.com>,
        Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>,
        Mathias Krause <minipli@googlemail.com>,
        Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>,
        jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v2] powercap, intel_rapl.c, fix BIOS lock check
Message-ID: <20151209085355.6442a508@icelake>
In-Reply-To: <1449667872-11197-1-git-send-email-prarit@redhat.com>
References: <1449667872-11197-1-git-send-email-prarit@redhat.com>
Organization: OTC
X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed,  9 Dec 2015 08:31:12 -0500
Prarit Bhargava <prarit@redhat.com> wrote:

> Intel RAPL initialized on several systems where the BIOS lock bit (msr
> 0x610, bit 63) was set.  This occured because the return value of
> rapl_read_data_raw() was being checked, rather than the value of the
> variable passed in, locked.
> 
> This patch properly implments the rapl_read_data_raw() call to check
> the variable locked, and now the Intel RAPL driver outputs the
> warning:
> 
> 	intel_rapl: RAPL package 0 domain package locked by BIOS
> 
> and does not initialize for the package.
> 
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Cc: Radivoje Jovanovic <radivoje.jovanovic@intel.com>
> Cc: Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>
> Cc: Mathias Krause <minipli@googlemail.com>
> Cc: Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> 
> [v2]: fix brackets

Acked-by: Jacob Pan <jacob.jun.pan@linux.intel.com>

Good catch by Seiichi, thanks.