Re: [patch RESEND] atp870u: 64 bit bug in atp885_init()

Julia Lawall
2015-12-09T18:11:26Z

On Wed, 9 Dec 2015, Dan Carpenter wrote:

> We should add a tag to indicate that we are sending a patch for a crappy
> driver.
>
> IMHO-this-driver-is-garbage: Your Name <email>
>
> If it got 10 votes of no confidence it would be moved to staging and
> then deleted.

Forgive my ignorance, but what is the exact procedure? For example, the
following file: drivers/pcmcia/vrc4173_cardu.c contains the following
code: INIT_WORK(&socket->tq_work, cardu_bh, socket);. The last time
INIT_WORK took three arguments was Linux 2.6.19, so I think no one has
been compiling this code recently. There would be the .c file and the
associated .h file to move to staging, but it's less clear to me eg what
to do with the Kconfig entry and the Makefile entry. And is there
anything else to take into account?

thanks,
julia