From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753985AbbLIMCY (ORCPT ); Wed, 9 Dec 2015 07:02:24 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:33345 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751477AbbLIMCW (ORCPT ); Wed, 9 Dec 2015 07:02:22 -0500 Date: Wed, 9 Dec 2015 17:32:17 +0530 From: Sudip Mukherjee To: Richard Weinberger Cc: Artem Bityutskiy , David Woodhouse , Brian Norris , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH] UBI: fix return error code Message-ID: <20151209120217.GE24852@sudip-pc> References: <1448014460-1371-1-git-send-email-sudipm.mukherjee@gmail.com> <564EF353.2050806@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <564EF353.2050806@nod.at> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20, 2015 at 11:17:55AM +0100, Richard Weinberger wrote: > Am 20.11.2015 um 11:14 schrieb Sudip Mukherjee: > > We are checking dfs_rootdir for error value or NULL. But in the > > conditional ternary operator we returned -ENODEV if dfs_rootdir contains > > an error value and returned PTR_ERR(dfs_rootdir) if dfs_rootdir is NULL. > > So in the case of dfs_rootdir being NULL we actually assigned 0 to err > > and returned it to the caller implying a success. > > Lets return -ENODEV when dfs_rootdir is NULL else return > > PTR_ERR(dfs_rootdir). > > > > Signed-off-by: Sudip Mukherjee > > --- > > drivers/mtd/ubi/debug.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mtd/ubi/debug.c b/drivers/mtd/ubi/debug.c > > index b077e43..c4cb15a 100644 > > --- a/drivers/mtd/ubi/debug.c > > +++ b/drivers/mtd/ubi/debug.c > > @@ -236,7 +236,7 @@ int ubi_debugfs_init(void) > > > > dfs_rootdir = debugfs_create_dir("ubi", NULL); > > if (IS_ERR_OR_NULL(dfs_rootdir)) { > > - int err = dfs_rootdir ? -ENODEV : PTR_ERR(dfs_rootdir); > > + int err = dfs_rootdir ? PTR_ERR(dfs_rootdir) : -ENODEV; > > > > Nice catch! Hi Richard, It is still not on linus-next. Did you miss it? regards sudip