From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753628AbbLITO1 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 9 Dec 2015 14:14:27 -0500
Received: from mail.skyhub.de ([78.46.96.112]:54836 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753394AbbLITO0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 9 Dec 2015 14:14:26 -0500
Date: Wed, 9 Dec 2015 20:14:11 +0100
From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: Dave Hansen <dave.hansen@intel.com>,
        the arch/x86 maintainers <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "Yu, Yu-cheng" <yu-cheng.yu@intel.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: x86 fpu: command-line parameters broken post-FPU-rewrite
Message-ID: <20151209191411.GC10475@pd.tnic>
References: <566740E1.40608@intel.com>
 <20151209083209.GB15254@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20151209083209.GB15254@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 09, 2015 at 09:32:10AM +0100, Ingo Molnar wrote:
> 
> * Dave Hansen <dave.hansen@intel.com> wrote:
> 
> > Hey Ingo,
> > 
> > We were starting to look at reenabling XSAVES support and tried to use the 
> > 'noxsave' and 'noxsaves' kernel command-line options.  The rewrite moved the FPU 
> > initialization to before we even are parsing command-line options, even the 
> > early_param()s.
> > 
> > Do you have any preferences on how it gets fixed?
> > 
> > The most obvious thing would be to just defer as much of the FPU setup as we can 
> > until after parse_early_param() has happened.  The only other think I can think 
> > of doing would be to try to do some *really* early, simple, command-line parsing 
> > to look for 'noxsave' and friends.
> > 
> > Thoughts?
> 
> Hm, so given that having the FPU operational is key to a functioning kernel (and 
> other kernel subsystems may make use of FPU functionality), I'd rather bring 
> option parsing earlier than change the FPU setup sequence. FPU setup should be 
> done when we identify the CPU - not 'very late' as we used to.

We already have early cmdline parsing: arch/x86/lib/cmdline.c

See users for examples.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.