Re: Crash caused by "EDAC: Rip out the edac_subsys reference counting" (was Re: linux-next: Tree for Dec 8)

Scott Wood
2015-12-09T16:50:25Z

On Wed, 2015-12-09 at 17:03 +0100, Borislav Petkov wrote:
> On Wed, Dec 09, 2015 at 12:17:47PM +0100, Borislav Petkov wrote:
> > On Wed, Dec 09, 2015 at 09:32:47PM +1100, Michael Ellerman wrote:
> > > Presumably caused by the fact that edac_init() is subsys_initcall(),
> > > whereas
> > > corenet_gen_publish_devices() is arch_initcall().
> >
> > Thanks for the report!
> >
> > Hmm, interesting, can you send .config please?
> >
> > I need to fix this dependency properly - edac_core needs to have
> > finished loaded *before* any other EDAC driver loads. Every other order
> > is wrong.
>
> Yeah, see Johannes' patch.
>
> Btw, calling a driver's probe function from outside the driver is a new
> low in driver design. Tztztz...

It's not "a driver's probe function". There is no driver whose .probe() is
mpc85xx_pci_err_probe() -- the name is historical.

-Scott