From: Johan Hovold <johan@kernel.org>
To: "Geyslan G. Bem" <geyslan@gmail.com>
Cc: peter.senna@gmail.com, Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johan Hovold <johan@kernel.org>,
Robert Baldyga <r.baldyga@samsung.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: remove redundant conditions
Date: Thu, 10 Dec 2015 11:44:30 +0100 [thread overview]
Message-ID: <20151210104430.GE24965@localhost> (raw)
In-Reply-To: <1449712366-31365-1-git-send-email-geyslan@gmail.com>
On Wed, Dec 09, 2015 at 10:52:42PM -0300, Geyslan G. Bem wrote:
> This patch removes redundant conditions.
>
> - (!A || (A && B)) is the same as (!A || B).
> - (length && length > 5) can be reduced to a single evaluation.
>
> Caught by: cppcheck
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> ---
> drivers/usb/gadget/udc/s3c-hsudc.c | 2 +-
> drivers/usb/host/fhci-sched.c | 2 +-
> drivers/usb/musb/musb_gadget.c | 5 ++---
> drivers/usb/serial/io_edgeport.c | 35 ++++++++++++++---------------------
> drivers/usb/serial/mos7840.c | 2 +-
> 5 files changed, 19 insertions(+), 27 deletions(-)
Please split out (at least) the usb-serial changes into two patches.
Johan
next prev parent reply other threads:[~2015-12-10 10:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 1:52 [PATCH] usb: remove redundant conditions Geyslan G. Bem
2015-12-10 10:44 ` Johan Hovold [this message]
2015-12-10 10:50 ` Geyslan G. Bem
2015-12-10 14:50 ` Felipe Balbi
2015-12-10 14:58 ` Geyslan G. Bem
2015-12-10 15:13 ` Felipe Balbi
2015-12-10 15:16 ` Geyslan G. Bem
2015-12-10 15:37 ` Felipe Balbi
2015-12-10 15:17 ` David Laight
2015-12-10 15:29 ` Geyslan G. Bem
2015-12-10 15:35 ` Geyslan G. Bem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210104430.GE24965@localhost \
--to=johan@kernel.org \
--cc=balbi@ti.com \
--cc=geyslan@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox