From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754038AbbLJPGF (ORCPT <rfc822;w@1wt.eu>);
	Thu, 10 Dec 2015 10:06:05 -0500
Received: from mail-pf0-f181.google.com ([209.85.192.181]:35366 "EHLO
	mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753438AbbLJPFn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 10 Dec 2015 10:05:43 -0500
X-Greylist: delayed 483 seconds by postgrey-1.27 at vger.kernel.org; Thu, 10 Dec 2015 10:05:42 EST
Date: Thu, 10 Dec 2015 23:56:07 +0900
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Jan Kara <jack@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Petr Mladek <pmladek@suse.cz>,
        KY Srinivasan <kys@microsoft.com>,
        Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH 2/7] printk: Start printing handover kthreads on demand
Message-ID: <20151210145607.GB540@swordfish>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +static void printk_offload_init(void)
> +{
> +	mutex_lock(&printk_kthread_mutex);
> +	if (num_possible_cpus() <= 1) {
> +		/* Offloading doesn't make sense. Disable print offloading. */
> +		printk_offload_chars = 0;
> +	} else
> +		printk_start_offload_kthreads();
> +	mutex_unlock(&printk_kthread_mutex);
> +}

A silly minor nitpick

+	} else {
		printk_start_offload_kthreads();
+	}

	-ss