From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754445AbbLJPK2 (ORCPT ); Thu, 10 Dec 2015 10:10:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51970 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753992AbbLJPKY (ORCPT ); Thu, 10 Dec 2015 10:10:24 -0500 Date: Thu, 10 Dec 2015 09:10:21 -0600 From: Josh Poimboeuf To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCHSET 0/7] perf tools: Remove browser dependency from usage_with_options() Message-ID: <20151210151021.GD29872@treble.redhat.com> References: <1449716459-23004-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1449716459-23004-1-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 10, 2015 at 12:00:52PM +0900, Namhyung Kim wrote: > Hello, > > This patchset removes the UI browser dependency (specifically > exit_browser function) from option parser code. It'll help to > separate out the common code into a library. > > Now existing users of usage_with_options() were converted to call it > before setup_browser(). I think future users can notice the > difference when they test their code and will call it properly. > > It's available on 'perf/option-dependency-v1' branch on my tree > > git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git > > Thanks > Namhyung > > > Namhyung Kim (7): > perf annotate: Check argument before calling setup_browser() > perf annotate: Delay UI browser setup after initialization is done > perf kvm: Remove invocation of setup/exit_browser() > perf report: Check argument before calling setup_browser() > perf top: Delay UI browser setup after initialization is done > perf tools: Free strlist on error path > perf tools: Get rid of exit_browser() from usage_with_options() > > tools/perf/builtin-annotate.c | 33 ++++++++++++++++----------------- > tools/perf/builtin-kvm.c | 3 --- > tools/perf/builtin-report.c | 21 ++++++++++----------- > tools/perf/builtin-top.c | 14 +++++++------- > tools/perf/util/parse-options.c | 3 --- > tools/perf/util/thread_map.c | 1 + > 6 files changed, 34 insertions(+), 41 deletions(-) Thanks a lot Namhyung! For the series, Reviewed-by: Josh Poimboeuf -- Josh