Re: [PATCHSET 0/7] perf tools: Remove browser dependency from usage_with_options()

Josh Poimboeuf
2015-12-10T15:10:28Z

On Thu, Dec 10, 2015 at 12:00:52PM +0900, Namhyung Kim wrote:
> Hello,
>
> This patchset removes the UI browser dependency (specifically
> exit_browser function) from option parser code. It'll help to
> separate out the common code into a library.
>
> Now existing users of usage_with_options() were converted to call it
> before setup_browser(). I think future users can notice the
> difference when they test their code and will call it properly.
>
> It's available on 'perf/option-dependency-v1' branch on my tree
>
> git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
>
> Thanks
> Namhyung
>
>
> Namhyung Kim (7):
> perf annotate: Check argument before calling setup_browser()
> perf annotate: Delay UI browser setup after initialization is done
> perf kvm: Remove invocation of setup/exit_browser()
> perf report: Check argument before calling setup_browser()
> perf top: Delay UI browser setup after initialization is done
> perf tools: Free strlist on error path
> perf tools: Get rid of exit_browser() from usage_with_options()
>
> tools/perf/builtin-annotate.c | 33 ++++++++++++++++-----------------
> tools/perf/builtin-kvm.c | 3 ---
> tools/perf/builtin-report.c | 21 ++++++++++-----------
> tools/perf/builtin-top.c | 14 +++++++-------
> tools/perf/util/parse-options.c | 3 ---
> tools/perf/util/thread_map.c | 1 +
> 6 files changed, 34 insertions(+), 41 deletions(-)

Thanks a lot Namhyung!

For the series,

Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>

--
Josh