From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755033AbbLJRfa (ORCPT ); Thu, 10 Dec 2015 12:35:30 -0500 Received: from mail-ob0-f171.google.com ([209.85.214.171]:36441 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751991AbbLJRf1 (ORCPT ); Thu, 10 Dec 2015 12:35:27 -0500 Date: Thu, 10 Dec 2015 09:35:24 -0800 From: Benjamin Young To: Sudip Mukherjee Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fixed coding style problems based on checkpatch.pl for goldfish_audio.c Message-ID: <20151210173523.GA2530@gmail.com> References: <20151209234602.GA3817@gmail.com> <20151210071319.GA5814@sudip-pc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151210071319.GA5814@sudip-pc> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 10, 2015 at 12:43:19PM +0530, Sudip Mukherjee wrote: > On Wed, Dec 09, 2015 at 03:46:02PM -0800, Benjamin Young wrote: > > From f18a3e5f155f5258d2d19ac6b56bfaafa2ad470b Mon Sep 17 00:00:00 2001 > > From: Benjamin Young > > Date: Wed, 9 Dec 2015 13:45:00 -0800 > > Subject: [PATCH] Fixed coding style problems based on checkpatch.pl for > > goldfish_audio.c > > This should not be here. > You have not given in commit message and you are doing multiple changes > in this patch. Please split them into separate patch, each patch doing > only a single type of change. > > regards > sudip Thanks Sudip I will fix this by creating two new patches. One for the comparison to null checks and the other for space between operators. Was there anything else which I could improve on for this commit? Thanks, Benjamin