From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754592AbbLJRnh (ORCPT ); Thu, 10 Dec 2015 12:43:37 -0500 Received: from mail.kernel.org ([198.145.29.136]:38651 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751688AbbLJRng (ORCPT ); Thu, 10 Dec 2015 12:43:36 -0500 Date: Thu, 10 Dec 2015 14:43:32 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Josh Poimboeuf Subject: Re: [PATCH 5/7] perf top: Delay UI browser setup after initialization is done Message-ID: <20151210174332.GD17996@kernel.org> References: <1449716459-23004-1-git-send-email-namhyung@kernel.org> <1449716459-23004-6-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449716459-23004-6-git-send-email-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Dec 10, 2015 at 12:00:57PM +0900, Namhyung Kim escreveu: > Move setup_browser after all necessary initialization is done. This > is to remove the browser dependency from usage_with_options() and > friends. So, please try: perf top -C 0 -p 1 So that we get a command line validation error that will cause cmd_top to trip this: status = target__validate(target); if (status) { target__strerror(target, status, errbuf, BUFSIZ); ui__warning("%s\n", errbuf); } ui__warning() will emit the warning to stdio, and this message will be seen only after the user exits the tool: [root@ssdandy ~]# perf top -C 0 -p 1 Warning: PID/TID switch overriding CPU Where without this patch the user will be warning with a popup window, that has to be acknowledged with an enter before proceeding. Looking at the other patches to check which can be processed now, leaving this one for later. - Arnaldo > Cc: Josh Poimboeuf > Signed-off-by: Namhyung Kim > --- > tools/perf/builtin-top.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c > index 7e2e72e6d9d1..75134e106a62 100644 > --- a/tools/perf/builtin-top.c > +++ b/tools/perf/builtin-top.c > @@ -1252,13 +1252,6 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused) > goto out_delete_evlist; > } > > - if (top.use_stdio) > - use_browser = 0; > - else if (top.use_tui) > - use_browser = 1; > - > - setup_browser(false); > - > status = target__validate(target); > if (status) { > target__strerror(target, status, errbuf, BUFSIZ); > @@ -1326,6 +1319,13 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused) > sigaction(SIGWINCH, &act, NULL); > } > > + if (top.use_stdio) > + use_browser = 0; > + else if (top.use_tui) > + use_browser = 1; > + > + setup_browser(false); > + > status = __cmd_top(&top); > > out_delete_evlist: > -- > 2.6.2