From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754622AbbLJRwL (ORCPT ); Thu, 10 Dec 2015 12:52:11 -0500 Received: from mail.kernel.org ([198.145.29.136]:39246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754233AbbLJRwJ (ORCPT ); Thu, 10 Dec 2015 12:52:09 -0500 Date: Thu, 10 Dec 2015 14:52:05 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Josh Poimboeuf Subject: Re: [PATCH 5/7] perf top: Delay UI browser setup after initialization is done Message-ID: <20151210175205.GE17996@kernel.org> References: <1449716459-23004-1-git-send-email-namhyung@kernel.org> <1449716459-23004-6-git-send-email-namhyung@kernel.org> <20151210174332.GD17996@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151210174332.GD17996@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Dec 10, 2015 at 02:43:32PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Dec 10, 2015 at 12:00:57PM +0900, Namhyung Kim escreveu: > > Move setup_browser after all necessary initialization is done. This > > is to remove the browser dependency from usage_with_options() and > > friends. > > So, please try: > > perf top -C 0 -p 1 > > So that we get a command line validation error that will cause cmd_top > to trip this: > > status = target__validate(target); > if (status) { > target__strerror(target, status, errbuf, BUFSIZ); > ui__warning("%s\n", errbuf); > } > > ui__warning() will emit the warning to stdio, and this message will be > seen only after the user exits the tool: So, this one should be enough, ack? >>From 83c5eb5124210a579f174d37af8f0ce4f21264ff Mon Sep 17 00:00:00 2001 From: Arnaldo Carvalho de Melo Date: Thu, 10 Dec 2015 14:48:45 -0300 Subject: [PATCH] perf report: Do show usage message when failing to create cpu/thread maps This is necessary to get rid of the browser dependency from usage_with_options() and its friends. Because we validate the targets which are used to create the cpu/thread maps and inform the user about any override performed via the chosen UI, we don't need to call the usage routine for that. Cc: Namhyung Kim Cc: Josh Poimboeuf Cc: David Ahern Cc: Jiri Olsa Cc: Peter Zijlstra Link: http://lkml.kernel.org/n/tip-slu7lj7buzpwgop1vo9la8ma@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-top.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 7e2e72e6d9d1..4eb9c6906219 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -1279,8 +1279,10 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused) if (target__none(target)) target->system_wide = true; - if (perf_evlist__create_maps(top.evlist, target) < 0) - usage_with_options(top_usage, options); + if (perf_evlist__create_maps(top.evlist, target) < 0) { + ui__error("Not enough memory to create thread/cpu maps\n"); + goto out_delete_evlist; + } if (!top.evlist->nr_entries && perf_evlist__add_default(top.evlist) < 0) { -- 1.8.3.1