From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754152AbbLKO4t (ORCPT ); Fri, 11 Dec 2015 09:56:49 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:34206 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753417AbbLKO4s (ORCPT ); Fri, 11 Dec 2015 09:56:48 -0500 Date: Fri, 11 Dec 2015 15:56:43 +0100 From: Peter Zijlstra To: Alexander Shishkin Cc: Ingo Molnar , linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, Arnaldo Carvalho de Melo , Mathieu Poirier Subject: Re: [PATCH v0 3/5] perf: Introduce instruction trace filtering Message-ID: <20151211145643.GS6356@twins.programming.kicks-ass.net> References: <1449840998-29902-1-git-send-email-alexander.shishkin@linux.intel.com> <1449840998-29902-4-git-send-email-alexander.shishkin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449840998-29902-4-git-send-email-alexander.shishkin@linux.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 11, 2015 at 03:36:36PM +0200, Alexander Shishkin wrote: > @@ -5921,6 +6010,8 @@ static void perf_event_comm_event(struct perf_comm_event *comm_event) > > comm_event->event_id.header.size = sizeof(comm_event->event_id) + size; > > + if (comm_event->event_id.header.misc == PERF_RECORD_MISC_COMM_EXEC) > + perf_event_aux(perf_itrace_exec, comm_event, NULL, true); Maybe put this in perf_event_exec() ? > perf_event_aux(perf_event_comm_output, > comm_event, > NULL, false);