From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754659AbbLKWjh (ORCPT ); Fri, 11 Dec 2015 17:39:37 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:49508 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199AbbLKWjg (ORCPT ); Fri, 11 Dec 2015 17:39:36 -0500 Date: Fri, 11 Dec 2015 23:39:30 +0100 From: Peter Zijlstra To: Alexander Shishkin Cc: Ingo Molnar , linux-kernel@vger.kernel.org, vince@deater.net, eranian@google.com, Arnaldo Carvalho de Melo , Mathieu Poirier Subject: Re: [PATCH v0 3/5] perf: Introduce instruction trace filtering Message-ID: <20151211223930.GE6356@twins.programming.kicks-ass.net> References: <1449840998-29902-1-git-send-email-alexander.shishkin@linux.intel.com> <1449840998-29902-4-git-send-email-alexander.shishkin@linux.intel.com> <20151211152854.GX6356@twins.programming.kicks-ass.net> <20151211170029.GI6373@twins.programming.kicks-ass.net> <87egesykm1.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87egesykm1.fsf@ashishki-desk.ger.corp.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 11, 2015 at 07:13:10PM +0200, Alexander Shishkin wrote: > Peter Zijlstra writes: > > On second thought; we should not inherit the filters at all. > > > > We should always use event->parent (if exists) for filters. Otherwise > > inherited events will get different filters if you change the filter > > after clone. > > But children will have different mappings, _can_ have. > so the actual filter > configurations will still differ between parents and children. I guess I > could split the filter in two parts: one that's defined by the user and > one that we calculated from vma addresses, that we later program into > hardware. /me confused, isn't that what you already do? In any case, since inherited counters are uncontrollable (they have no filedesc of their own) and you cannot a priory tell what a child will go do, let alone a child of a child. It really makes no sense to have different filters on different parts of the inherited tree.