From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, kirk@reisers.ca,
gregkh@linuxfoundation.org, speakup@linux-speakup.org,
Saurabh Sengar <saurabh.truth@gmail.com>,
linux-kernel@vger.kernel.org, samuel.thibault@ens-lyon.org,
chris@the-brannons.com
Subject: Re: [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var
Date: Sat, 12 Dec 2015 15:41:24 +0530 [thread overview]
Message-ID: <20151212101124.GB13516@sudip-pc> (raw)
In-Reply-To: <20151212084025.GN5284@mwanda>
On Sat, Dec 12, 2015 at 11:40:25AM +0300, Dan Carpenter wrote:
> On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote:
> > On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote:
> > > This patch does the following:
> > > * changed the complicated if statements to simple case statements
> > > * in case of E_DEFAULT, no need to return error as ERESTART,
> > > because this is the user asked for. Hence function should return success.
> > > * ret variable is 0 always, hence removed it.
> > > * removed one ternary operator, as it was always returning the status value only,
> > > and hence removed the status variable too
> >
> > That becomes 4 different changes. Please break them into separate
> > patches.
>
> It's cleaning up one function so you could argue that it's just one
> thing.
Then maybe that should have been mentioned in the commit message along
with mentioning point wise the different changes made.
regards
sudip
next prev parent reply other threads:[~2015-12-12 10:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 13:05 [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var Saurabh Sengar
2015-12-09 5:17 ` Sudip Mukherjee
2015-12-12 8:40 ` Dan Carpenter
2015-12-12 8:49 ` Saurabh Sengar
2015-12-12 10:11 ` Sudip Mukherjee [this message]
2015-12-12 11:58 ` Saurabh Sengar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151212101124.GB13516@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=chris@the-brannons.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=saurabh.truth@gmail.com \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox