From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752181AbbLNCS3 (ORCPT ); Sun, 13 Dec 2015 21:18:29 -0500 Received: from mail.kernel.org ([198.145.29.136]:51484 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951AbbLNCS1 (ORCPT ); Sun, 13 Dec 2015 21:18:27 -0500 Date: Mon, 14 Dec 2015 10:18:01 +0800 From: Shawn Guo To: Stefan Agner Cc: kernel@pengutronix.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ARM: dts: vf-colibri: split PWM pinctrl Message-ID: <20151214021801.GA25756@tiger> References: <1449094307-6011-1-git-send-email-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449094307-6011-1-git-send-email-stefan@agner.ch> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 02, 2015 at 02:11:46PM -0800, Stefan Agner wrote: > Split PWM pins into separate pinctrl nodes to allow overrides which > select pins individually. This is useful for carrier boards which use > only one pin for PWM and would like to use the other pin for a > different purpose. > > Signed-off-by: Stefan Agner > --- > arch/arm/boot/dts/vf-colibri.dtsi | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi > index e5949b9..924b660 100644 > --- a/arch/arm/boot/dts/vf-colibri.dtsi > +++ b/arch/arm/boot/dts/vf-colibri.dtsi > @@ -74,12 +74,12 @@ > > &pwm0 { > pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_pwm0>; > + pinctrl-0 = <&pinctrl_pwm0_a &pinctrl_pwm0_c>; > }; > > &pwm1 { > pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_pwm1>; > + pinctrl-0 = <&pinctrl_pwm1_b &pinctrl_pwm1_d>; > }; It may make more sense to define these pwm nodes in the final board level dts with only defining the pins that are actually used on the board. Shawn > > &uart0 { > @@ -195,16 +195,26 @@ > >; > }; > > - pinctrl_pwm0: pwm0grp { > + pinctrl_pwm0_a: pwm0agrp { > fsl,pins = < > VF610_PAD_PTB0__FTM0_CH0 0x1182 > + >; > + }; > + > + pinctrl_pwm0_c: pwm0cgrp { > + fsl,pins = < > VF610_PAD_PTB1__FTM0_CH1 0x1182 > >; > }; > > - pinctrl_pwm1: pwm1grp { > + pinctrl_pwm1_b: pwm1bgrp { > fsl,pins = < > VF610_PAD_PTB8__FTM1_CH0 0x1182 > + >; > + }; > + > + pinctrl_pwm1_d: pwm1dgrp { > + fsl,pins = < > VF610_PAD_PTB9__FTM1_CH1 0x1182 > >; > }; > -- > 2.6.2 > >