From: Jerry Hoemann <jerry.hoemann@hpe.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
elliott@hpe.com, jmoyer <jmoyer@redhat.com>,
krivenok.dmitry@gmail.com, linda.knippers@hpe.com,
Robert Moore <robert.moore@intel.com>, Lv <lv.zheng@intel.com>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
linux-nvdimm@ml01.01.org,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/6] acpica: Correct parameter type to acpi_evaluate_dsm
Date: Sun, 13 Dec 2015 20:20:58 -0700 [thread overview]
Message-ID: <20151214032058.GA19337@tevye.fc.hp.com> (raw)
In-Reply-To: <CAJZ5v0jiR80vFxLUN-L7hcChb8m6gasf77TMV6onOprSh_CVHA@mail.gmail.com>
On Mon, Dec 14, 2015 at 03:07:22AM +0100, Rafael J. Wysocki wrote:
> On Mon, Dec 14, 2015 at 2:54 AM, Jerry Hoemann <jerry.hoemann@hpe.com> wrote:
> > The ACPI spec speicifies that arguments "Revision ID" and
> > "Function Index" to a _DSM are type "Integer." Type Integers
> > are 64 bit quantities.
> >
> > The function evaluate_dsm specifies these types as simple "int"
> > which are 32 bits. Correct type passed to acpi_evaluate_dsm
> > and its callers and derived callers to pass correct type.
> >
> > acpi_check_dsm and acpi_evaluate_dsm_typed had similar issue
> > and were corrected as well.
> >
> > Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
>
> The changes look OK to me, but this is not ACPICA material.
>
> Please change the subject to something like "ACPI / utils: Fix
> acpi_evaluate_dsm() argument type".
>
> Thanks,
> Rafael
Will do. thanks.
--
-----------------------------------------------------------------------------
Jerry Hoemann Software Engineer Hewlett Packard Enterprise
-----------------------------------------------------------------------------
next prev parent reply other threads:[~2015-12-14 3:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 1:54 [PATCH v3 0/6] nvdimm: Add an IOCTL pass thru for DSM calls Jerry Hoemann
2015-12-14 1:54 ` [PATCH v3 1/6] acpica: Correct parameter type to acpi_evaluate_dsm Jerry Hoemann
2015-12-14 2:07 ` Rafael J. Wysocki
2015-12-14 3:20 ` Jerry Hoemann [this message]
2015-12-14 1:54 ` [PATCH v3 2/6] nvdimm: Clean-up access mode check Jerry Hoemann
2015-12-14 1:54 ` [PATCH v3 3/6] nvdimm: Add wrapper for IOCTL pass thru Jerry Hoemann
2015-12-14 1:54 ` [PATCH v3 4/6] nvdimm: Fix security issue with DSM IOCTL Jerry Hoemann
2015-12-14 1:54 ` [PATCH v3 5/6] nvdimm: Increase max envelope size for IOCTL Jerry Hoemann
2015-12-14 1:54 ` [PATCH v3 6/6] nvdimm: Add IOCTL pass thru functions Jerry Hoemann
2015-12-14 17:33 ` [PATCH v4 0/6] nvdimm: Add an IOCTL pass thru for DSM calls Jerry Hoemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214032058.GA19337@tevye.fc.hp.com \
--to=jerry.hoemann@hpe.com \
--cc=dan.j.williams@intel.com \
--cc=elliott@hpe.com \
--cc=jmoyer@redhat.com \
--cc=krivenok.dmitry@gmail.com \
--cc=lenb@kernel.org \
--cc=linda.knippers@hpe.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox