Re: [PATCH 2/2] extcon: arizona: Update device tree binding for mic detect configurations

Charles Keepax
2015-12-14T09:18:57Z

On Mon, Dec 14, 2015 at 11:03:58AM +0900, Chanwoo Choi wrote:
> Hi Charles,
>
> On 2015년 12월 11일 02:08, Charles Keepax wrote:
> > Update the device tree binding documentation to include documentation for
> > the wlf,micd-configs property that is used to specify the configurations
> > for headset polarity detection (CTIA / OTMP).
> >
> > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> > ---
> > Documentation/devicetree/bindings/extcon/extcon-arizona.txt | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/extcon/extcon-arizona.txt b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> > index 238e10e..fd9b898 100644
> > --- a/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> > +++ b/Documentation/devicetree/bindings/extcon/extcon-arizona.txt
> > @@ -37,5 +37,13 @@ Optional properties:
> > milliseconds.
> > - wlf,micd-force-micbias : Force MICBIAS continuously on during microphone
> > detection.
> > + - wlf,micd-configs : Headset polarity configurations (generally used for
> > + detection of CTIA / OMTP headsets), the field can be of variable length
> > + but should always be a multiple of 3 cells long, each three cell group
> > + represents one polarity configuration.
> > + The first cell defines the accessory detection pin, zero will use MICDET1
> > + and all other values will use MICDET2.
> > + The second cell represents the MICBIAS to be used.
> > + The third cell represents the value of the micd-pol-gpio pin.
>
> I think that you better to add the example using the 'wlf,micd-configs'
> to improve the understanding of using this property.
> because the number of 'wlf,micd-configs' value is not fixed.
>
> Also,
> How about do you add the real example for all arizona properties on separate patch?

Yeah that seems sensible I will do a patch to add an example to
this file.

Thanks,
Charles