From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v3 14/17] perf: Remove subcmd dependencies on strbuf
Date: Mon, 14 Dec 2015 08:11:55 -0600 [thread overview]
Message-ID: <20151214141155.GC30746@treble.redhat.com> (raw)
In-Reply-To: <20151214102551.GA9449@krava.brq.redhat.com>
On Mon, Dec 14, 2015 at 11:25:51AM +0100, Jiri Olsa wrote:
> On Sun, Dec 13, 2015 at 10:18:14PM -0600, Josh Poimboeuf wrote:
> > Introduce and use new astrcat() and astrcatf() functions which replace
> > the strbuf functionality for subcmd.
>
> hum, would it be better then to put strbuf into lib as well?
Based on the v2 discussion, I think we don't want to move it to lib,
because it's also used by perf, and it's outside the scope of 'subcmd'.
But we could certainly duplicate it for internal use by the library.
Arnaldo, what do you think?
--
Josh
next prev parent reply other threads:[~2015-12-14 14:11 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 4:18 [PATCH v3 00/17] perf tools: Move perf subcommand framework to a library Josh Poimboeuf
2015-12-14 4:18 ` [PATCH v3 01/17] perf build: Remove unnecessary line in Makefile.feature Josh Poimboeuf
2015-12-14 10:05 ` Jiri Olsa
2015-12-14 15:16 ` Arnaldo Carvalho de Melo
2015-12-18 8:47 ` [tip:perf/core] " tip-bot for Josh Poimboeuf
2015-12-14 4:18 ` [PATCH v3 02/17] tools build: Fix feature Makefile dependencies for 'O=' Josh Poimboeuf
2015-12-14 10:08 ` Jiri Olsa
2015-12-14 14:02 ` Josh Poimboeuf
2015-12-14 14:29 ` [PATCH v3.1 " Josh Poimboeuf
2015-12-14 15:16 ` Arnaldo Carvalho de Melo
2015-12-14 15:29 ` Jiri Olsa
2015-12-14 15:38 ` Josh Poimboeuf
2015-12-14 15:55 ` Jiri Olsa
2015-12-14 16:03 ` Josh Poimboeuf
2015-12-14 18:32 ` [PATCH v3.2] tools build: Fix feature Makefile issues with 'O=' Josh Poimboeuf
2015-12-14 4:18 ` [PATCH v3 03/17] perf test: Add Build file to dependencies for llvm-src-*.c Josh Poimboeuf
2015-12-14 10:10 ` Jiri Olsa
2015-12-14 15:17 ` Arnaldo Carvalho de Melo
2015-12-18 8:47 ` [tip:perf/core] " tip-bot for Josh Poimboeuf
2015-12-14 4:18 ` [PATCH v3 04/17] perf test: remove tarpkg at end of test Josh Poimboeuf
2015-12-18 8:48 ` [tip:perf/core] perf test: Remove " tip-bot for Josh Poimboeuf
2015-12-14 4:18 ` [PATCH v3 05/17] perf build: Fix 'make clean' Josh Poimboeuf
2015-12-14 10:14 ` Jiri Olsa
2015-12-14 15:18 ` Arnaldo Carvalho de Melo
2015-12-18 8:48 ` [tip:perf/core] " tip-bot for Josh Poimboeuf
2015-12-14 4:18 ` [PATCH v3 06/17] perf build: Rename LIB_PATH -> API_PATH Josh Poimboeuf
2015-12-14 10:34 ` Jiri Olsa
2015-12-14 15:19 ` Arnaldo Carvalho de Melo
2015-12-18 8:49 ` [tip:perf/core] " tip-bot for Josh Poimboeuf
2015-12-14 4:18 ` [PATCH v3 07/17] perf: Create pager.h Josh Poimboeuf
2015-12-18 8:49 ` [tip:perf/core] perf tools: " tip-bot for Josh Poimboeuf
2015-12-14 4:18 ` [PATCH v3 08/17] perf: Remove check for unused PERF_PAGER_IN_USE Josh Poimboeuf
2015-12-18 8:49 ` [tip:perf/core] perf tools: " tip-bot for Josh Poimboeuf
2015-12-14 4:18 ` [PATCH v3 09/17] perf: Move help_unknown_cmd() to its own file Josh Poimboeuf
2015-12-18 8:50 ` [tip:perf/core] perf tools: " tip-bot for Josh Poimboeuf
2015-12-14 4:18 ` [PATCH v3 10/17] perf: Provide subcmd configuration at runtime Josh Poimboeuf
2015-12-14 10:33 ` Jiri Olsa
2015-12-14 14:06 ` Josh Poimboeuf
2015-12-14 4:18 ` [PATCH v3 11/17] perf: Remove 'perf' from subcmd function and variable names Josh Poimboeuf
2015-12-14 4:18 ` [PATCH v3 12/17] perf: Convert parse-options.c internal functions to static Josh Poimboeuf
2015-12-18 8:50 ` [tip:perf/core] perf tools: " tip-bot for Josh Poimboeuf
2015-12-14 4:18 ` [PATCH v3 13/17] perf: Document the fact that parse_options*() may exit Josh Poimboeuf
2015-12-14 4:18 ` [PATCH v3 14/17] perf: Remove subcmd dependencies on strbuf Josh Poimboeuf
2015-12-14 10:25 ` Jiri Olsa
2015-12-14 14:11 ` Josh Poimboeuf [this message]
2015-12-14 15:44 ` Arnaldo Carvalho de Melo
2015-12-14 16:05 ` Josh Poimboeuf
2015-12-14 17:50 ` Arnaldo Carvalho de Melo
2015-12-14 18:04 ` Josh Poimboeuf
2015-12-14 4:18 ` [PATCH v3 15/17] perf: Finalize subcmd independence Josh Poimboeuf
2015-12-14 10:32 ` Jiri Olsa
2015-12-14 14:13 ` Josh Poimboeuf
2015-12-14 15:27 ` Jiri Olsa
2015-12-14 15:51 ` Arnaldo Carvalho de Melo
2015-12-14 4:18 ` [PATCH v3 16/17] perf subcmd: Create subcmd library Josh Poimboeuf
2015-12-14 4:18 ` [PATCH v3 17/17] tools subcmd: Rename subcmd header include guards Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214141155.GC30746@treble.redhat.com \
--to=jpoimboe@redhat.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox