From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751423AbbLNOL6 (ORCPT ); Mon, 14 Dec 2015 09:11:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58010 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751292AbbLNOL5 (ORCPT ); Mon, 14 Dec 2015 09:11:57 -0500 Date: Mon, 14 Dec 2015 08:11:55 -0600 From: Josh Poimboeuf To: Jiri Olsa Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Namhyung Kim Subject: Re: [PATCH v3 14/17] perf: Remove subcmd dependencies on strbuf Message-ID: <20151214141155.GC30746@treble.redhat.com> References: <3454b82dcc683d8ae581ca123de47578ee5a5e3c.1449965119.git.jpoimboe@redhat.com> <20151214102551.GA9449@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20151214102551.GA9449@krava.brq.redhat.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 14, 2015 at 11:25:51AM +0100, Jiri Olsa wrote: > On Sun, Dec 13, 2015 at 10:18:14PM -0600, Josh Poimboeuf wrote: > > Introduce and use new astrcat() and astrcatf() functions which replace > > the strbuf functionality for subcmd. > > hum, would it be better then to put strbuf into lib as well? Based on the v2 discussion, I think we don't want to move it to lib, because it's also used by perf, and it's outside the scope of 'subcmd'. But we could certainly duplicate it for internal use by the library. Arnaldo, what do you think? -- Josh