Re: [PATCH v3 01/17] perf build: Remove unnecessary line in Makefile.feature

Jiri Olsa
2015-12-14T10:05:11Z

On Sun, Dec 13, 2015 at 10:18:01PM -0600, Josh Poimboeuf wrote:
> This line always silently fails because it doesn't add the 'test-'
> prefix to the .bin file.
>
> And it seems to be unnecessary anyway: the line immediately after it
> does all the individual feature checks.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> ---
> tools/build/Makefile.feature | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> index 37ff4c9..b8c31ec 100644
> --- a/tools/build/Makefile.feature
> +++ b/tools/build/Makefile.feature
> @@ -101,7 +101,6 @@ ifeq ($(feature-all), 1)
> #
> $(foreach feat,$(FEATURE_TESTS),$(call feature_set,$(feat)))
> else
> - $(shell $(MAKE) OUTPUT=$(OUTPUT_FEATURES) CFLAGS="$(EXTRA_CFLAGS)" LDFLAGS=$(LDFLAGS) -i -j -C $(feature_dir) $(addsuffix .bin,$(FEATURE_TESTS)) >/dev/null 2>&1)
> $(foreach feat,$(FEATURE_TESTS),$(call feature_check,$(feat)))

ugh, nice ;-)

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka