Re: [PATCH v3 15/17] perf: Finalize subcmd independence

Jiri Olsa
2015-12-14T10:32:24Z

On Sun, Dec 13, 2015 at 10:18:15PM -0600, Josh Poimboeuf wrote:
> For the files that will be moved to the subcmd library, remove all their
> perf-specific includes and duplicate any needed functionality.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> ---
> tools/perf/util/exec_cmd.c | 75 +++++++++++++++++++++++++++++++++++++----
> tools/perf/util/help.c | 47 +++++++++++++++++++++++---
> tools/perf/util/help.h | 4 ++-
> tools/perf/util/pager.c | 7 +++-
> tools/perf/util/parse-options.c | 68 +++++++++++++++++++++++--------------
> tools/perf/util/parse-options.h | 2 +-
> tools/perf/util/run-command.c | 16 ++++++---
> tools/perf/util/run-command.h | 2 ++
> tools/perf/util/sigchain.c | 3 +-
> tools/perf/util/subcmd-util.h | 67 ++++++++++++++++++++++++++++++++++++
> tools/perf/util/util.h | 14 --------
> 11 files changed, 247 insertions(+), 58 deletions(-)

this duplicates functions that we have already in perf,
I think we better move them into lib first..
strlcpy, die, xrealloc, ALLOC_GROW

and probably some others...

jirka