Re: [PATCH v3 15/17] perf: Finalize subcmd independence

Jiri Olsa
2015-12-14T15:27:55Z

On Mon, Dec 14, 2015 at 08:13:59AM -0600, Josh Poimboeuf wrote:
> On Mon, Dec 14, 2015 at 11:32:20AM +0100, Jiri Olsa wrote:
> > On Sun, Dec 13, 2015 at 10:18:15PM -0600, Josh Poimboeuf wrote:
> > > For the files that will be moved to the subcmd library, remove all their
> > > perf-specific includes and duplicate any needed functionality.
> > >
> > > Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> > > ---
> > > tools/perf/util/exec_cmd.c | 75 +++++++++++++++++++++++++++++++++++++----
> > > tools/perf/util/help.c | 47 +++++++++++++++++++++++---
> > > tools/perf/util/help.h | 4 ++-
> > > tools/perf/util/pager.c | 7 +++-
> > > tools/perf/util/parse-options.c | 68 +++++++++++++++++++++++--------------
> > > tools/perf/util/parse-options.h | 2 +-
> > > tools/perf/util/run-command.c | 16 ++++++---
> > > tools/perf/util/run-command.h | 2 ++
> > > tools/perf/util/sigchain.c | 3 +-
> > > tools/perf/util/subcmd-util.h | 67 ++++++++++++++++++++++++++++++++++++
> > > tools/perf/util/util.h | 14 --------
> > > 11 files changed, 247 insertions(+), 58 deletions(-)
> >
> > this duplicates functions that we have already in perf,
> > I think we better move them into lib first..
> > strlcpy, die, xrealloc, ALLOC_GROW
> >
> > and probably some others...
>
> The duplication was an intentional decision we made in the v2 discussion
> in order to keep the library's scope focused on 'subcmd'.

I see, I haven't read those completely.. I guess we can unify
it (librarize it) after this change is done

jirka