Re: [PATCH v3 03/17] perf test: Add Build file to dependencies for llvm-src-*.c

Jiri Olsa
2015-12-14T10:10:48Z

On Sun, Dec 13, 2015 at 10:18:03PM -0600, Josh Poimboeuf wrote:
> Because the Build file writes source code to the generated llvm-src-*.c
> files, it should be listed as one of the dependencies, so that any
> future changes to the code being echoed won't require a 'make clean'.

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> ---
> tools/perf/tests/Build | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build
> index 0ff8a97..f23fb7e 100644
> --- a/tools/perf/tests/Build
> +++ b/tools/perf/tests/Build
> @@ -35,21 +35,21 @@ perf-y += llvm.o llvm-src-base.o llvm-src-kbuild.o llvm-src-prologue.o
> perf-y += bpf.o
> perf-y += topology.o
>
> -$(OUTPUT)tests/llvm-src-base.c: tests/bpf-script-example.c
> +$(OUTPUT)tests/llvm-src-base.c: tests/bpf-script-example.c tests/Build
> $(call rule_mkdir)
> $(Q)echo '#include <tests/llvm.h>' > $@
> $(Q)echo 'const char test_llvm__bpf_base_prog[] =' >> $@
> $(Q)sed -e 's/"/\\"/g' -e 's/\(.*\)/"\1\\n"/g' $< >> $@
> $(Q)echo ';' >> $@
>
> -$(OUTPUT)tests/llvm-src-kbuild.c: tests/bpf-script-test-kbuild.c
> +$(OUTPUT)tests/llvm-src-kbuild.c: tests/bpf-script-test-kbuild.c tests/Build
> $(call rule_mkdir)
> $(Q)echo '#include <tests/llvm.h>' > $@
> $(Q)echo 'const char test_llvm__bpf_test_kbuild_prog[] =' >> $@
> $(Q)sed -e 's/"/\\"/g' -e 's/\(.*\)/"\1\\n"/g' $< >> $@
> $(Q)echo ';' >> $@
>
> -$(OUTPUT)tests/llvm-src-prologue.c: tests/bpf-script-test-prologue.c
> +$(OUTPUT)tests/llvm-src-prologue.c: tests/bpf-script-test-prologue.c tests/Build
> $(call rule_mkdir)
> $(Q)echo '#include <tests/llvm.h>' > $@
> $(Q)echo 'const char test_llvm__bpf_test_prologue_prog[] =' >> $@
> --
> 2.4.3
>