From: Peter Zijlstra <peterz@infradead.org>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: mingo@redhat.com, bsegall@google.com, dietmar.eggemann@arm.com,
linux-kernel@vger.kernel.org, yuyang.du@intel.com,
pjt@google.com, morten.rasmussen@arm.com
Subject: Re: [PATCH v2] sched/fair: fix mul overflow on 32-bit systems
Date: Mon, 14 Dec 2015 15:35:28 +0100 [thread overview]
Message-ID: <20151214143528.GP6357@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1450097243-30137-1-git-send-email-aryabinin@virtuozzo.com>
On Mon, Dec 14, 2015 at 03:47:23PM +0300, Andrey Ryabinin wrote:
> Make 'r' 64-bit type to avoid overflow in 'r * LOAD_AVG_MAX'
> on 32-bit systems:
> UBSAN: Undefined behaviour in kernel/sched/fair.c:2785:18
> signed integer overflow:
> 87950 * 47742 cannot be represented in type 'int'
>
> Fixes: 9d89c257dfb9 ("sched/fair: Rewrite runnable load and utilization average tracking")
> Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
Thanks!
next prev parent reply other threads:[~2015-12-14 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 12:47 [PATCH v2] sched/fair: fix mul overflow on 32-bit systems Andrey Ryabinin
2015-12-14 14:35 ` Peter Zijlstra [this message]
2016-01-06 18:47 ` [tip:sched/core] sched/fair: Fix multiplication " tip-bot for Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214143528.GP6357@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aryabinin@virtuozzo.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=pjt@google.com \
--cc=yuyang.du@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox