From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752273AbbLNQDi (ORCPT ); Mon, 14 Dec 2015 11:03:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60522 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751380AbbLNQDh (ORCPT ); Mon, 14 Dec 2015 11:03:37 -0500 Date: Mon, 14 Dec 2015 10:03:36 -0600 From: Josh Poimboeuf To: Jiri Olsa Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Namhyung Kim Subject: Re: [PATCH v3.1 02/17] tools build: Fix feature Makefile dependencies for 'O=' Message-ID: <20151214160336.GD11552@treble.redhat.com> References: <20151214100851.GD27640@krava.brq.redhat.com> <20151214140250.GA30746@treble.redhat.com> <20151214142907.GE30746@treble.redhat.com> <20151214152939.GC21388@krava.brq.redhat.com> <20151214153815.GC11552@treble.redhat.com> <20151214155528.GA1696@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20151214155528.GA1696@krava.brq.redhat.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 14, 2015 at 04:55:28PM +0100, Jiri Olsa wrote: > On Mon, Dec 14, 2015 at 09:38:15AM -0600, Josh Poimboeuf wrote: > > On Mon, Dec 14, 2015 at 04:29:39PM +0100, Jiri Olsa wrote: > > > On Mon, Dec 14, 2015 at 08:29:07AM -0600, Josh Poimboeuf wrote: > > > > Signed-off-by: Josh Poimboeuf > > > > > > you might want to work on your changelogs > > > a little.. aaand actually include some ;-) > > > > Well, I thought the subject said it all :-) > > well, you could be more specific, like: > - how was it broken before > - what did you do to fix it > - how you added a test case to ensure this will never happen again ;-) > > it makes the life of reviewer a bit easier, anyway: > > Acked-by: Jiri Olsa Thanks. I'll try to be more verbose in future changelogs. -- Josh