From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752991AbbLNQmG (ORCPT ); Mon, 14 Dec 2015 11:42:06 -0500 Received: from mail.skyhub.de ([78.46.96.112]:54492 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752156AbbLNQmD (ORCPT ); Mon, 14 Dec 2015 11:42:03 -0500 Date: Mon, 14 Dec 2015 17:41:57 +0100 From: Borislav Petkov To: Steven Rostedt Cc: LKML Subject: Re: [PATCH] ftrace: Kill ftrace_caller_end label Message-ID: <20151214164157.GD10520@pd.tnic> References: <1450109314-20323-1-git-send-email-bp@alien8.de> <20151214113027.03d3587c@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151214113027.03d3587c@gandalf.local.home> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 14, 2015 at 11:30:27AM -0500, Steven Rostedt wrote: > On Mon, 14 Dec 2015 17:08:34 +0100 > Borislav Petkov wrote: > > > From: Borislav Petkov > > > > One of ftrace_caller_and and ftrace_return is redundant so unify them. > > s/_and/_end/ Whoops. > > Rename ftrace_return to ftrace_epilogue to mean that everything after > > that label represents, like an afterword, work which happens *after* the > > ftrace call, e.g., the function graph tracer for one. > > > > Beef up the comment about the code contents and layout before > > ftrace_epilogue label. > > According to http://www.thefreedictionary.com/epilog > > ep·i·logue also ep·i·log (ĕp′ə-lôg′, -lŏg′) (n). > 1. > a. A short poem or speech spoken directly to the audience following > the conclusion of a play. > > Hmm, that doesn't fit. Huh, why doesn't that fit? "A short code executed following the conclusion of a trampoline..." :-) > b. The performer who delivers such a short poem or speech. > > Maybe people can think ftrace as a poem. But people will never think > that I give such a short speech. LOL. > 2. A short addition or concluding section at the end of a literary > work, often dealing with the future of its characters. Also called > afterword. > > Ah, "afterword" also doesn't fit, unless you mean "characters" as a set > of "char []". Which I guess the trampoline would fit. > > 3. An event which reflects meaningfully on a recently ended conflict or > struggle. > > Ah! This looks like the best match! Thus, this should be stated in the > changelog! It is simply supposed to denote "stuff done after". You can call it ftrace_post_work, ftrace_after, ... I'm sure you're going to fix it up as you like it when applying :-) Thanks! -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.