From: Mark Brown <broonie@kernel.org>
To: Xiubo Li <lixiubo@cmss.chinamobile.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: flat: introduce register striding to save some memories
Date: Mon, 14 Dec 2015 17:57:56 +0000 [thread overview]
Message-ID: <20151214175756.GW5727@sirena.org.uk> (raw)
In-Reply-To: <1450077274-25942-1-git-send-email-lixiubo@cmss.chinamobile.com>
[-- Attachment #1: Type: text/plain, Size: 792 bytes --]
On Mon, Dec 14, 2015 at 03:14:34PM +0800, Xiubo Li wrote:
> static int regcache_flat_write(struct regmap *map, unsigned int reg,
> unsigned int value)
> {
> + unsigned int index = reg / map->reg_stride;
So, this does save some memory. On the other hand one of the big goals
for the flat cache is to be as fast as possible to match the performance
of MMIO and divisions aren't the cheapest operations. If this was the
rbtree cache then it'd not be an issue but in the flat cache speed is
definitely the top priority, at least by default.
I'm guessing for your particular register maps the performance isn't too
big an issue... do you have any numbers for how much space you're
saving overall? Is it worth finding a way to make this possible to
enable on maps that benefit?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-12-14 17:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 7:14 [PATCH] regmap: flat: introduce register striding to save some memories Xiubo Li
2015-12-14 17:57 ` Mark Brown [this message]
[not found] ` <566FD138.4010601@cmss.chinamobile.com>
2015-12-18 8:23 ` [PATCH] regmap: flat: introduce register striding to save somememories Mark Brown
[not found] ` <2015121816593812599420@cmss.chinamobile.com>
2015-12-30 17:58 ` Mark Brown
2015-12-31 1:36 ` [PATCH] regmap: flat: introduce register striding to savesomememories Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214175756.GW5727@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixiubo@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox