From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: "Marciniszyn, Mike" <mike.marciniszyn@intel.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Doug Ledford <dledford@redhat.com>,
Nicholas Mc Guire <hofrat@osadl.org>,
"Hefty, Sean" <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>
Subject: Re: [PATCH 1/3] staging/rdma/hfi1: consolidate kmalloc_array+memset into kcalloc
Date: Mon, 14 Dec 2015 21:09:54 +0300 [thread overview]
Message-ID: <20151214180954.GZ5284@mwanda> (raw)
In-Reply-To: <20151214174123.GB22987@osadl.at>
On Mon, Dec 14, 2015 at 05:41:23PM +0000, Nicholas Mc Guire wrote:
> I obviously made a real mess here.
> I incorrectly concluded that rxcontext is 0 which it is not in some cases
Yep. Plus you build tested it but assumed that the unused variable
warning must have been there in the original... I've done that for
static checker warnings. Lesson learned, hopefully.
regards,
dan carpenter
prev parent reply other threads:[~2015-12-14 18:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 14:43 [PATCH 1/3] staging/rdma/hfi1: consolidate kmalloc_array+memset into kcalloc Nicholas Mc Guire
2015-12-14 14:43 ` [PATCH 2/3] staging/rdma/hfi1: check return value of kcalloc Nicholas Mc Guire
2015-12-14 15:21 ` Marciniszyn, Mike
2015-12-14 17:36 ` Nicholas Mc Guire
2015-12-14 14:43 ` [PATCH 3/3] staging/rdma/hfi1: fix build warning Nicholas Mc Guire
2015-12-14 15:28 ` [PATCH 1/3] staging/rdma/hfi1: consolidate kmalloc_array+memset into kcalloc Marciniszyn, Mike
2015-12-14 17:41 ` Nicholas Mc Guire
2015-12-14 18:09 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214180954.GZ5284@mwanda \
--to=dan.carpenter@oracle.com \
--cc=der.herr@hofr.at \
--cc=devel@driverdev.osuosl.org \
--cc=dledford@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hal.rosenstock@gmail.com \
--cc=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox