From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933110AbbLOEJ1 (ORCPT ); Mon, 14 Dec 2015 23:09:27 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34653 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932321AbbLOEJZ (ORCPT ); Mon, 14 Dec 2015 23:09:25 -0500 Date: Mon, 14 Dec 2015 19:08:08 -0500 From: Sanidhya Solanki To: Jason Cooper Cc: gregkh@linuxfoundation.org, mathieu.poirier@linaro.org, deepa.kernel@gmail.com, brcnakalin@gmail.com, vatikaharlalka@gmail.com, sudipm.mukherjee@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header file. Message-ID: <20151214190808.364f1c9b@gmail.com> In-Reply-To: <20151208130905.GX6520@io.lakedaemon.net> References: <1449542244-637-1-git-send-email-jpage.lkml@gmail.com> <20151208130905.GX6520@io.lakedaemon.net> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The original code defined macros in the source code, making it harder to read. Moved them to the header file, as per the TODO file. Updated the TODO file. Signed-off-by: Sanidhya Solanki --- drivers/staging/skein/TODO | 1 - drivers/staging/skein/skein_block.c | 6 ------ drivers/staging/skein/skein_block.h | 7 +++++++ 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/skein/TODO b/drivers/staging/skein/TODO index cd3508d..e3de0c7 100644 --- a/drivers/staging/skein/TODO +++ b/drivers/staging/skein/TODO @@ -1,6 +1,5 @@ skein/threefish TODO - - move macros into appropriate header files - add / pass test vectors - module support diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 45b4732..2120392 100644 --- a/drivers/staging/skein/skein_block.c +++ b/drivers/staging/skein/skein_block.c @@ -26,12 +26,6 @@ #define SKEIN_LOOP 001 /* default: unroll 256 and 512, but not 1024 */ #endif -#define BLK_BITS (WCNT * 64) /* some useful definitions for code here */ -#define KW_TWK_BASE (0) -#define KW_KEY_BASE (3) -#define ks (kw + KW_KEY_BASE) -#define ts (kw + KW_TWK_BASE) - #ifdef SKEIN_DEBUG #define debug_save_tweak(ctx) \ { \ diff --git a/drivers/staging/skein/skein_block.h b/drivers/staging/skein/skein_block.h index 9d40f4a..0fd4bfe 100644 --- a/drivers/staging/skein/skein_block.h +++ b/drivers/staging/skein/skein_block.h @@ -7,6 +7,13 @@ ** This algorithm and source code is released to the public domain. ** ************************************************************************/ + +#define BLK_BITS (WCNT * 64) /* some useful definitions for code here */ +#define KW_TWK_BASE (0) +#define KW_KEY_BASE (3) +#define ks (kw + KW_KEY_BASE) +#define ts (kw + KW_TWK_BASE) + #ifndef _SKEIN_BLOCK_H_ #define _SKEIN_BLOCK_H_ -- 2.5.0