From: Peter Zijlstra <peterz@infradead.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, jstancek@redhat.com, clm@fb.com,
vladimir.murzin@arm.com, pjt@google.com, efault@gmx.de,
tglx@linutronix.de, hpa@zytor.com, neilb@suse.de
Subject: Re: [PATCH] sched/wait: Fix the signal handling fix
Date: Mon, 14 Dec 2015 22:11:22 +0100 [thread overview]
Message-ID: <20151214211122.GZ6357@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20151214185004.GA27367@redhat.com>
On Mon, Dec 14, 2015 at 07:50:04PM +0100, Oleg Nesterov wrote:
> > + ret = (*action)(&q->key, mode);
>
> And every action() should check signal_pending_state()...
>
> So why we can't change __wait_on_bit/etc instead and remove all the signal-
> pending checks from the callbacks? It seems that we can just check
> signal_pending_state() before prepare_to_wait(). Or perhaps we can add
> another helper which acts like prepare_to_wait_event().
>
> Yes, some callers want -EINTR, some -ERESTARTSYS, but this shouldn't be a
> problem.
>
> And sorry if this was already discussed, another case when I am trying to
> return to lkml with a lot of unread emails.
Yes that looks like a viable cleanup. But at least now we have a base
that's working for everyone.
I'll try and do some patches tomorrow.
prev parent reply other threads:[~2015-12-14 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-13 21:11 [PATCH] sched/wait: Fix the signal handling fix Peter Zijlstra
2015-12-14 18:50 ` Oleg Nesterov
2015-12-14 21:11 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151214211122.GZ6357@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=clm@fb.com \
--cc=efault@gmx.de \
--cc=hpa@zytor.com \
--cc=jstancek@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=oleg@redhat.com \
--cc=pjt@google.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox