From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andi Kleen <andi@firstfloor.org>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 6/6] perf tools: Try to show pretty printed output for dynamic sort keys
Date: Tue, 15 Dec 2015 07:36:37 -0300 [thread overview]
Message-ID: <20151215103637.GZ6843@kernel.org> (raw)
In-Reply-To: <20151215090329.GE16565@krava.brq.redhat.com>
Em Tue, Dec 15, 2015 at 10:03:29AM +0100, Jiri Olsa escreveu:
> On Tue, Dec 15, 2015 at 12:46:13AM +0900, Namhyung Kim wrote:
> > Each tracepoint event has format string for print to improve
> > readability. Try to parse the output and match the field name. If it
> > finds one, use that for the result. If not, fallbacks to the original
> > output.
> >
> > For example, sort on kmem:kmalloc.gfp_flags looks like below:
> > (Note: libtraceevent plugins are not installed on my system. They might
> > affect the output below)
> >
> > Before:
> > # Overhead Command gfp_flags
> > # ........ ....... ..........
> > #
> > 99.89% perf 32848
> > 0.06% sleep 208
> > 0.03% perf 32976
> > 0.01% perf 208
> >
> > After:
> > # Overhead Command gfp_flags
> > # ........ ....... ...................
> > #
> > 99.89% perf GFP_NOFS|GFP_ZERO
> > 0.06% sleep GFP_KERNEL
> > 0.03% perf GFP_KERNEL|GFP_ZERO
> > 0.01% perf GFP_KERNEL
>
> hum, maybe we want some way to switch back to numbers?
Or remove repetitive stuff like GFP_? I guess this was done already for
perf kmem?
- Arnaldo
next prev parent reply other threads:[~2015-12-15 10:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 15:46 [RFC/PATCHSET 0/6] perf tools: Support dynamic sort keys for tracepoints (v1) Namhyung Kim
2015-12-14 15:46 ` [PATCH 1/6] perf hist: Pass struct sample to __hists__add_entry() Namhyung Kim
2015-12-14 15:46 ` [PATCH 2/6] perf hist: Save raw_data/size for tracepoint events Namhyung Kim
2015-12-14 15:46 ` [PATCH 3/6] tools lib traceevent: Factor out and export print_event_field() Namhyung Kim
2015-12-14 15:46 ` [PATCH 4/6] perf tools: Pass evlist to setup_sorting() Namhyung Kim
2015-12-14 15:46 ` [PATCH 5/6] perf tools: Add dynamic sort key for tracepoint events Namhyung Kim
2015-12-15 8:53 ` Jiri Olsa
2015-12-15 12:07 ` Namhyung Kim
2015-12-15 12:22 ` Jiri Olsa
2015-12-15 12:37 ` Namhyung Kim
2015-12-14 15:46 ` [PATCH 6/6] perf tools: Try to show pretty printed output for dynamic sort keys Namhyung Kim
2015-12-15 9:03 ` Jiri Olsa
2015-12-15 10:36 ` Arnaldo Carvalho de Melo [this message]
2015-12-15 12:13 ` Namhyung Kim
2015-12-15 12:24 ` Jiri Olsa
2015-12-15 12:42 ` Namhyung Kim
2015-12-15 12:52 ` Jiri Olsa
2015-12-14 17:47 ` [RFC/PATCHSET 0/6] perf tools: Support dynamic sort keys for tracepoints (v1) Arnaldo Carvalho de Melo
2015-12-14 22:32 ` David Ahern
2015-12-15 1:41 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151215103637.GZ6843@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox