From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965070AbbLOL02 (ORCPT ); Tue, 15 Dec 2015 06:26:28 -0500 Received: from foss.arm.com ([217.140.101.70]:48060 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964917AbbLOL01 (ORCPT ); Tue, 15 Dec 2015 06:26:27 -0500 Date: Tue, 15 Dec 2015 11:26:13 +0000 From: Mark Rutland To: Will Deacon Cc: "Suzuki K. Poulose" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, marc.zyngier@arm.com Subject: Re: [RFC PATCH v3 2/8] arm64: Move cpu_die_early to smp.c Message-ID: <20151215112612.GG31299@leverpostej> References: <1449655039-22022-1-git-send-email-suzuki.poulose@arm.com> <1449655039-22022-3-git-send-email-suzuki.poulose@arm.com> <20151215112338.GD9452@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151215112338.GD9452@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 15, 2015 at 11:23:39AM +0000, Will Deacon wrote: > > +/* > > + * Kill the calling secondary CPU, early in bringup before it is turned > > + * online. > > + */ > > +void cpu_die_early(void) > > +{ > > + int cpu = smp_processor_id(); > > + > > + pr_crit("CPU%d: will not boot\n", cpu); > > + > > + /* Mark this CPU absent */ > > + set_cpu_present(cpu, 0); > > + > > +#ifdef CONFIG_HOTPLUG_CPU > > + /* Check if we can park ourselves */ > > + if (cpu_ops[cpu] && cpu_ops[cpu]->cpu_die) > > IS_ENABLED? The definition of struct cpu_ops has cpu_die in an #ifdef CONFIG_HOTPLUG_CPU. Mark.