From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965196AbbLOMHq (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Dec 2015 07:07:46 -0500
Received: from mail-pf0-f179.google.com ([209.85.192.179]:33906 "EHLO
	mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S964999AbbLOMHp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Dec 2015 07:07:45 -0500
Date: Tue, 15 Dec 2015 21:07:03 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        LKML <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Andi Kleen <andi@firstfloor.org>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 5/6] perf tools: Add dynamic sort key for tracepoint
 events
Message-ID: <20151215120703.GA12003@danjae.kornet>
References: <1450107973-2447-1-git-send-email-namhyung@kernel.org>
 <1450107973-2447-6-git-send-email-namhyung@kernel.org>
 <20151215085309.GD16565@krava.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20151215085309.GD16565@krava.brq.redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 15, 2015 at 09:53:09AM +0100, Jiri Olsa wrote:
> On Tue, Dec 15, 2015 at 12:46:12AM +0900, Namhyung Kim wrote:
> 
> SNIP
> 
> > 
> >   $ perf report -s comm,sched:sched_switch.next_pid,sched:sched_switch.next_comm --stdio
> >   ...
> >   # Overhead  Command            next_pid         next_comm
> >   # ........  ...............  ..........  ................
> >   #
> >       20.86%  swapper               17773   transmission-gt
> >        9.64%  transmission-gt           0         swapper/0
> >        9.16%  transmission-gt           0         swapper/2
> >        5.25%  swapper                 109      kworker/0:1H
> >        5.21%  kworker/0:1H              0         swapper/0
> >        2.14%  netctl-auto               0         swapper/2
> >        1.98%  netctl-auto               0         swapper/0
> >        1.98%  swapper                6524            Xephyr
> >        1.98%  swapper               27478       netctl-auto
> >        1.78%  transmission-gt           0         swapper/3
> >        1.53%  Xephyr                    0         swapper/0
> >        1.29%  netctl-auto               0         swapper/1
> >        1.29%  swapper               27476       netctl-auto
> >        1.21%  netctl-auto               0         swapper/3
> >        1.17%  swapper                 233    irq/33-iwlwifi
> > 
> > Note that pid 0 exists for each cpu so have comm of 'swapper/N'.
> 
> could we also add by default all tracepoint fields in case none
> is specified and the event to display is tracepoint?

Seems like a good suggestion.  We can check if there's only one
tracepoint event, then use dynamic sort keys for all fields.  But I
think we should skip common fields in that case.

> 
> also an extra field that would hold/show the 'print fmt' display ? 

Do you want a single extra field per event or per field?

Thanks,
Namhyung