From: Borislav Petkov <bp@suse.de>
To: "Raj, Ashok" <ashok.raj@intel.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
kvm@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
Gong Chen <gong.chen@intel.com>, Gleb Natapov <gleb@kernel.org>,
linux-kernel@vger.kernel.org, qemu-devel@nongnu.org,
Andi Kleen <andi.kleen@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU
Date: Tue, 15 Dec 2015 14:04:46 +0100 [thread overview]
Message-ID: <20151215130446.GE26000@pd.tnic> (raw)
In-Reply-To: <20151215001726.GA22215@otc-brkl-03.jf.intel.com>
On Mon, Dec 14, 2015 at 07:17:27PM -0500, Raj, Ashok wrote:
> I can see how this hurts.. since the poller isn't doing cpu model
> specific stuff..?
The poller sees mca_cfg.ser set on an AMD guest and then the whole
handling/decoding goes wrong.
> in the LMCE case, even if you advertise MCG_LMCE_P in MCG_CAP, the
> guest kernel wont call intel_init_lmce() only from mce_intel.c.. so
> the same problem won't happen.
You shouldn't advertise MCG_LMCE_P if the guest is not Intel. Those MCG
bits should be in the CPU model descriptor X86CPUDefinition.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2015-12-15 13:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 19:41 [Patch V2 1/2] x86,mce: Basic support to add LMCE support to QEMU Ashok Raj
2015-12-10 19:41 ` [Patch V2 2/2] x86, mce: Need to translate GPA to HPA to inject error in guest Ashok Raj
2015-12-12 3:13 ` Chen, Gong
2015-12-14 16:23 ` [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU Eduardo Habkost
2015-12-14 16:37 ` Borislav Petkov
2015-12-14 19:11 ` Raj, Ashok
2015-12-14 18:32 ` Eduardo Habkost
2015-12-14 22:37 ` Borislav Petkov
2015-12-15 0:17 ` Raj, Ashok
2015-12-15 13:04 ` Borislav Petkov [this message]
2015-12-15 15:42 ` Eduardo Habkost
2015-12-14 19:05 ` Raj, Ashok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151215130446.GE26000@pd.tnic \
--to=bp@suse.de \
--cc=andi.kleen@intel.com \
--cc=ashok.raj@intel.com \
--cc=ehabkost@redhat.com \
--cc=gleb@kernel.org \
--cc=gong.chen@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox