From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933629AbbLONE6 (ORCPT ); Tue, 15 Dec 2015 08:04:58 -0500 Received: from mx2.suse.de ([195.135.220.15]:50979 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933364AbbLONEz (ORCPT ); Tue, 15 Dec 2015 08:04:55 -0500 Date: Tue, 15 Dec 2015 14:04:46 +0100 From: Borislav Petkov To: "Raj, Ashok" Cc: Eduardo Habkost , kvm@vger.kernel.org, Tony Luck , Gong Chen , Gleb Natapov , linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, Andi Kleen , Paolo Bonzini Subject: Re: [Qemu-devel] [Patch V2 1/2] x86, mce: Basic support to add LMCE support to QEMU Message-ID: <20151215130446.GE26000@pd.tnic> References: <1449776482-26070-1-git-send-email-ashok.raj@intel.com> <20151214162356.GA5314@thinpad.lan.raisama.net> <20151214163738.GJ11630@pd.tnic> <20151214191145.GB18012@otc-brkl-03.jf.intel.com> <20151214223716.GK11630@pd.tnic> <20151215001726.GA22215@otc-brkl-03.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151215001726.GA22215@otc-brkl-03.jf.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 14, 2015 at 07:17:27PM -0500, Raj, Ashok wrote: > I can see how this hurts.. since the poller isn't doing cpu model > specific stuff..? The poller sees mca_cfg.ser set on an AMD guest and then the whole handling/decoding goes wrong. > in the LMCE case, even if you advertise MCG_LMCE_P in MCG_CAP, the > guest kernel wont call intel_init_lmce() only from mce_intel.c.. so > the same problem won't happen. You shouldn't advertise MCG_LMCE_P if the guest is not Intel. Those MCG bits should be in the CPU model descriptor X86CPUDefinition. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --