From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933576AbbLONbD (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Dec 2015 08:31:03 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50491 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S933557AbbLONa7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Dec 2015 08:30:59 -0500
Date: Tue, 15 Dec 2015 08:30:58 -0500
From: Vivek Goyal <vgoyal@redhat.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
        Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH 2/3] block: make blk-throttle.c explicitly non-modular
Message-ID: <20151215133058.GA20903@redhat.com>
References: <1450037044-27628-1-git-send-email-paul.gortmaker@windriver.com>
 <1450037044-27628-3-git-send-email-paul.gortmaker@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1450037044-27628-3-git-send-email-paul.gortmaker@windriver.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Paul,

This looks reasonable to me. Ccing Tejun.

Thanks
Vivek

On Sun, Dec 13, 2015 at 03:04:03PM -0500, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
> 
> config BLK_DEV_THROTTLING
>   bool "Block layer bio throttling support"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the couple traces of modularity so that when reading the
> code there is no doubt it is builtin-only.
> 
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
> 
> Cc: Vivek Goyal <vgoyal@redhat.com>
> Cc: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>  block/blk-throttle.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/block/blk-throttle.c b/block/blk-throttle.c
> index 2149a1ddbacf..bec1dedf4061 100644
> --- a/block/blk-throttle.c
> +++ b/block/blk-throttle.c
> @@ -4,7 +4,7 @@
>   * Copyright (C) 2010 Vivek Goyal <vgoyal@redhat.com>
>   */
>  
> -#include <linux/module.h>
> +#include <linux/init.h>
>  #include <linux/slab.h>
>  #include <linux/blkdev.h>
>  #include <linux/bio.h>
> @@ -1590,5 +1590,4 @@ static int __init throtl_init(void)
>  
>  	return blkcg_policy_register(&blkcg_policy_throtl);
>  }
> -
> -module_init(throtl_init);
> +device_initcall(throtl_init);
> -- 
> 2.6.1