From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965401AbbLORXi (ORCPT ); Tue, 15 Dec 2015 12:23:38 -0500 Received: from mga04.intel.com ([192.55.52.120]:48507 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965176AbbLORXg (ORCPT ); Tue, 15 Dec 2015 12:23:36 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,433,1444719600"; d="scan'208";a="13660121" Date: Tue, 15 Dec 2015 22:56:49 +0530 From: Vinod Koul To: Geert Uytterhoeven Cc: Linus Walleij , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Lee Jones , dmaengine@vger.kernel.org, Linux-sh list Subject: Re: [PATCH] dmaengine: use phys_addr_t for slave configuration Message-ID: <20151215172649.GK1854@localhost> References: <1366967214-20776-1-git-send-email-linus.walleij@linaro.org> <20150710081411.GF836@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 15, 2015 at 11:48:24AM +0100, Geert Uytterhoeven wrote: > Hi Vinod, > > On Fri, Jul 10, 2015 at 10:14 AM, Vinod Koul wrote: > > On Wed, Jul 08, 2015 at 12:12:52PM +0200, Geert Uytterhoeven wrote: > >> On Fri, Apr 26, 2013 at 11:06 AM, Linus Walleij > >> wrote: > >> > The documentation already says these are physical addresses, and > >> > we have concluded that any translation into the DMA address space > >> > needs to reside in the dmaengine driver, so change the type of > >> > the passed arguments. > >> > > >> > Cc: Arnd Bergmann > >> > Cc: Lee Jones > >> > Cc: Vinod Koul > >> > Signed-off-by: Linus Walleij > >> > >> What's the status of this one, which has been acked by Lee and Arnd? > > Looks to have slipped thru. I will redo it > > Ping? I should be able to do this in next few days... > > > -- > > ~Vinod > > > >> > >> Thanks! > >> > >> > --- > >> > include/linux/dmaengine.h | 4 ++-- > >> > 1 file changed, 2 insertions(+), 2 deletions(-) > >> > > >> > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h > >> > index 91ac8da..681df5f9 100644 > >> > --- a/include/linux/dmaengine.h > >> > +++ b/include/linux/dmaengine.h > >> > @@ -361,8 +361,8 @@ enum dma_slave_buswidth { > >> > */ > >> > struct dma_slave_config { > >> > enum dma_transfer_direction direction; > >> > - dma_addr_t src_addr; > >> > - dma_addr_t dst_addr; > >> > + phys_addr_t src_addr; > >> > + phys_addr_t dst_addr; > >> > enum dma_slave_buswidth src_addr_width; > >> > enum dma_slave_buswidth dst_addr_width; > >> > u32 src_maxburst; > >> > -- > >> > 1.8.1.4 > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- ~Vinod