From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932897AbbLPMAJ (ORCPT ); Wed, 16 Dec 2015 07:00:09 -0500 Received: from mail-lb0-f179.google.com ([209.85.217.179]:36075 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752789AbbLPMAG (ORCPT ); Wed, 16 Dec 2015 07:00:06 -0500 Date: Wed, 16 Dec 2015 14:00:02 +0200 From: "Kirill A. Shutemov" To: Dave Hansen Cc: "Kirill A. Shutemov" , Hugh Dickins , Andrea Arcangeli , Andrew Morton , Vlastimil Babka , Christoph Lameter , Naoya Horiguchi , Jerome Marchand , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 6/9] rmap: support file THP Message-ID: <20151216120002.GA17677@node.shutemov.name> References: <1447889136-6928-1-git-send-email-kirill.shutemov@linux.intel.com> <1447889136-6928-7-git-send-email-kirill.shutemov@linux.intel.com> <565E096D.7000105@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <565E096D.7000105@intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 01, 2015 at 12:56:13PM -0800, Dave Hansen wrote: > On 11/18/2015 03:25 PM, Kirill A. Shutemov wrote: > > -void page_add_file_rmap(struct page *page) > > +void page_add_file_rmap(struct page *page, bool compound) > > I take it we have to pass 'compound' in explicitly because > PageCompound() could be true, but we don't want to do a compound > mapping. This is true for those weirdo sound driver allocations and a > few other ones, right? Right. Also more common case will be PTE-mapped THPs as we have now for anon-THP. Basically, we mirror what was done for anon rmap interface. -- Kirill A. Shutemov