From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966276AbbLPR0R (ORCPT ); Wed, 16 Dec 2015 12:26:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46538 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934322AbbLPR0N (ORCPT ); Wed, 16 Dec 2015 12:26:13 -0500 Date: Wed, 16 Dec 2015 18:26:32 +0100 From: Oleg Nesterov To: Andrew Morton Cc: "Kirill A. Shutemov" , Naoya Horiguchi , Cyrill Gorcunov , linux-kernel@vger.kernel.org Subject: [PATCH] mm: /proc/pid/clear_refs: no need to clear VM_SOFTDIRTY in clear_soft_dirty_pmd() Message-ID: <20151216172632.GA7589@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org clear_soft_dirty_pmd() is called by clear_refs_write(CLEAR_REFS_SOFT_DIRTY), VM_SOFTDIRTY was already cleared before walk_page_range(). Signed-off-by: Oleg Nesterov --- fs/proc/task_mmu.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 187b3b5..1a02b15 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -817,9 +817,6 @@ static inline void clear_soft_dirty_pmd(struct vm_area_struct *vma, pmd = pmd_wrprotect(pmd); pmd = pmd_clear_soft_dirty(pmd); - if (vma->vm_flags & VM_SOFTDIRTY) - vma->vm_flags &= ~VM_SOFTDIRTY; - set_pmd_at(vma->vm_mm, addr, pmdp, pmd); } #else -- 1.5.5.1