From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966005AbbLPTQ0 (ORCPT ); Wed, 16 Dec 2015 14:16:26 -0500 Received: from mail.skyhub.de ([78.46.96.112]:44201 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752170AbbLPTQY (ORCPT ); Wed, 16 Dec 2015 14:16:24 -0500 Date: Wed, 16 Dec 2015 20:16:15 +0100 From: Borislav Petkov To: Dan Williams Cc: Toshi Kani , Andrew Morton , linux-arch@vger.kernel.org, Linux MM , "linux-kernel@vger.kernel.org" , Linus Torvalds , "Rafael J. Wysocki" Subject: Re: [PATCH 01/11] resource: Add System RAM resource type Message-ID: <20151216191614.GK29775@pd.tnic> References: <1450136246-17053-1-git-send-email-toshi.kani@hpe.com> <20151216122642.GE29775@pd.tnic> <1450280642.29051.76.camel@hpe.com> <20151216154916.GF29775@pd.tnic> <1450283759.20148.11.camel@hpe.com> <20151216174523.GH29775@pd.tnic> <20151216181712.GJ29775@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 16, 2015 at 10:57:52AM -0800, Dan Williams wrote: > Aside from "System RAM" checks I don't think any of these strcmp > usages are in fast paths. Sure, 0.1% slowdown here, 0.2% slowdown there... this is how you get a bloated kernel. In addition to that, using strings to identify resources is ugly. "It was there so we used it" is not an excuse. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.