From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Akshay Bhat <akshay.bhat@timesys.com>
Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
a.zummo@towertech.it, justin.waters@timesys.com
Subject: Re: [PATCH v2] rtc: Add Epson RX8010SJ RTC driver
Date: Wed, 16 Dec 2015 23:02:52 +0100 [thread overview]
Message-ID: <20151216220252.GJ8574@piout.net> (raw)
In-Reply-To: <1449171681-23701-1-git-send-email-akshay.bhat@timesys.com>
On 03/12/2015 at 14:41:21 -0500, Akshay Bhat wrote :
> This driver supports the following functions:
> - reading and setting time
> - alarms when connected to an IRQ
> - reading and clearing the voltage low flags
>
> Datasheet:
> http://www.epsondevice.com/docs/qd/en/DownloadServlet?id=ID000956
> Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com>
> ---
> Changes in v2:
> - Address comments from Alexandre Belloni
> - Update copyright info
> - Use i2c_smbus_read_byte_data/i2c_smbus_read_i2c_block_data directly
> - Use ffs for wday instead of bcd2bin
> - Fixes from checkpatch --strict
> - Limit date range to 2000 to 2100
> - Fix incorrect write to RX8010_WDAY
> - Do not clear VLF flag on power up
>
> drivers/rtc/Kconfig | 10 +
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-rx8010.c | 523 +++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 534 insertions(+)
> create mode 100644 drivers/rtc/rtc-rx8010.c
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-12-16 22:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 19:41 [PATCH v2] rtc: Add Epson RX8010SJ RTC driver Akshay Bhat
2015-12-16 22:02 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151216220252.GJ8574@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=akshay.bhat@timesys.com \
--cc=justin.waters@timesys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox