From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Jiri Slaby <jslaby@suse.cz>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/12] Rework tty_reopen()
Date: Wed, 16 Dec 2015 23:15:41 -0800 [thread overview]
Message-ID: <20151217071541.GB16626@kroah.com> (raw)
In-Reply-To: <5671868F.6090508@hurleysoftware.com>
On Wed, Dec 16, 2015 at 07:43:11AM -0800, Peter Hurley wrote:
> Hi Greg,
>
> This series has been reported to fix a regression with Redhat's kdump
> systemd service redirecting to /dev/console, when /dev/console is a
> serial port.
>
> The redirection consistently fails with EIO since
> "tty: Remove tty_wait_until_sent_from_close", which is new to 4.4-rc
> Prior to that patch, redirection would only occasionally fail with EIO. :)
>
> [ The systemd repeated hangup of /dev/console also seems to be the
> [ trigger for the serial driver crashes on hangup as well, which is
> [ fixed by the 19-patch "Fix driver crashes on hangup" series.
> [ That problem goes back to 3.10, but has only been reported recently,
> [ which leads me to believe recent changes in systemd /dev/console
> [ handling is a contributing factor (which I'm checking right now)
>
> Here are what I think are the options to resolve the regression:
>
> #1. Respin this series w/o the tty-next dependencies
> #2. Split this series into the minimum necessary to fix the regression
> #3. Revert from 4.4-rc (in revert order)
> "tty: Remove wait_event_interruptible_tty()"
> "tty: r3964: Replace/remove bogus tty lock use"
> "tty: r3964: Use tty->read_wait waitqueue"
> "tty: Remove tty_port::close_wait"
> "usb: gadget: gserial: Privatize close_wait"
> "tty: Remove ASYNC_CLOSING check in open()/hangup() methods"
> "tty: Remove tty_wait_until_sent_from_close()"
>
> Let me know how you'd like me to handle this.
Sounds like a reasonable approach, send the patches on and let's see
what they look like.
thanks,
greg k-h
next prev parent reply other threads:[~2015-12-17 7:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 2:25 [PATCH 00/12] Rework tty_reopen() Peter Hurley
2015-11-28 2:25 ` [PATCH 01/12] tty: Fix ldisc leak in failed tty_init_dev() Peter Hurley
2015-11-28 2:25 ` [PATCH 02/12] tty: Remove !tty check from free_tty_struct() Peter Hurley
2015-11-28 2:25 ` [PATCH 03/12] tty: Fix tty_init_termios() declaration Peter Hurley
2015-11-28 2:25 ` [PATCH 04/12] tty: Re-declare tty_driver_remove_tty() file scope Peter Hurley
2015-11-28 2:25 ` [PATCH 05/12] pty: Remove pty_unix98_shutdown() Peter Hurley
2015-11-28 2:25 ` [PATCH 06/12] tty: Remove __lockfunc annotation from tty lock functions Peter Hurley
2015-11-28 2:25 ` [PATCH 07/12] tty: Wait interruptibly for tty lock on reopen Peter Hurley
2015-11-28 2:25 ` [PATCH 08/12] pty: Prepare to redefine tty driver remove() interface Peter Hurley
2015-11-28 2:25 ` [PATCH 09/12] tty: Re-define " Peter Hurley
2015-11-28 2:25 ` [PATCH 10/12] tty: Consolidate noctty checks in tty_open() Peter Hurley
2015-11-28 2:25 ` [PATCH 11/12] tty: Refactor tty_open() Peter Hurley
2015-11-28 2:25 ` [PATCH 12/12] tty: Retry failed reopen if tty teardown in-progress Peter Hurley
2015-12-16 15:43 ` [PATCH 00/12] Rework tty_reopen() Peter Hurley
2015-12-17 5:53 ` Pratyush Anand
2015-12-17 7:15 ` Greg Kroah-Hartman [this message]
2016-01-10 5:13 ` [PATCH v2 00/10] " Peter Hurley
2016-01-10 5:13 ` [PATCH v2 01/10] tty: Wait interruptibly for tty lock on reopen Peter Hurley
2016-01-10 5:13 ` [PATCH v2 02/10] tty: Retry failed reopen if tty teardown in-progress Peter Hurley
2016-01-10 5:13 ` [PATCH v2 03/10] tty: Fix ldisc leak in failed tty_init_dev() Peter Hurley
2016-01-10 5:13 ` [PATCH v2 04/10] tty: Remove !tty check from free_tty_struct() Peter Hurley
2016-01-10 5:13 ` [PATCH v2 05/10] tty: Fix tty_init_termios() declaration Peter Hurley
2016-01-19 9:17 ` Johan Hovold
2016-01-10 5:13 ` [PATCH v2 06/10] tty: Re-declare tty_driver_remove_tty() file scope Peter Hurley
2016-01-10 5:13 ` [PATCH v2 07/10] pty: Remove pty_unix98_shutdown() Peter Hurley
2016-01-10 5:13 ` [PATCH v2 08/10] tty: Remove __lockfunc annotation from tty lock functions Peter Hurley
2016-01-10 5:13 ` [PATCH v2 09/10] tty: Consolidate noctty checks in tty_open() Peter Hurley
2016-03-26 17:58 ` Richard Weinberger
2016-03-26 19:06 ` Peter Hurley
2016-03-26 19:14 ` Richard Weinberger
2016-01-10 5:13 ` [PATCH v2 10/10] tty: Refactor tty_open() Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217071541.GB16626@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox